Skip to content

[spark-compete] fix(security): validate missionId in creator-mission to prevent path traversal #870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ifeoluwaaj wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[spark-compete] fix(security): validate missionId in creator-mission to prevent path traversal #870

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/lib/server/creator-mission.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,6 +366,14 @@ function creatorMissionDir(stateDir = spawnerStateDir()): string {
return path.join(stateDir, 'creator-missions');
}

/**
* Validates that a missionId contains only safe characters and cannot be used for path traversal.
* Mission IDs should be alphanumeric with hyphens/underscores only.
*/
function validateMissionId(missionId: string): boolean {
return /^[a-zA-Z0-9_-]+$/.test(missionId);
}

function pendingLoadPath(stateDir = spawnerStateDir()): string {
return path.join(stateDir, 'pending-load.json');
}
Expand Down Expand Up @@ -1653,6 +1661,10 @@ export async function readCreatorMissionTrace(
): Promise<CreatorMissionTrace | null> {
const missionId = input.missionId?.trim();
if (missionId) {
if (!validateMissionId(missionId)) {
console.error(`Invalid missionId format: ${missionId}`);
return null;
}
const filePath = creatorMissionPath(missionId, stateDir);
if (!existsSync(filePath)) return null;
return parseCreatorMissionTraceFile(await readFile(filePath, 'utf-8'));
Expand Down