feat:(dms-integration): Add dms-integration extension#204
Draft
AurelienJt wants to merge 5 commits intovicinaehq:mainfrom
Draft
feat:(dms-integration): Add dms-integration extension#204AurelienJt wants to merge 5 commits intovicinaehq:mainfrom
AurelienJt wants to merge 5 commits intovicinaehq:mainfrom
Conversation
…hyOS)" This reverts commit 1ef17e2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DankMaterialShell Vicinae Integration
Hello, this draft PR aims to determine if adding an extension integrating DMS functionalities and tools into Vicinae would make sense.
The Extension adds the following commands. (More detail in the extension README.md)
Search Files: Searched files using the integrated DMS search utility (dsearch). It also allows narrowing down the search scope with an optional argument. For DMS users, relying on the native tools is a huge convenience, as we expect the same search results and configuration methods across the DMS experience.
Reindex Files for Search Triggers async re-index with the user deciding if index should be fully rebuilt or simply updated using the option dropdown.
Settings: Opens the DMS settings, which for some reason don't include a .desktop file by themselves.
Note: The DMS file search indirectly re-implements Vicinae's file search. As such, I'll let the maintainers decide if adding this extension to the store makes sense. However, I stress the convenience of DMS users to be able to only use 1 file search accross the OS. Also, currently the DMS search command is named the same as the native one. This could be changed.
ToDo: Some errors can become too long to be displayed as toasts. Also, toasts disappear very quickly, making the error difficult to read.