(feat): Add "Gnome extensions" extension#215
Conversation
|
very cool idea! please rebase on main |
|
OK. I am going to do! |
|
I did it, but the commits are still in it. What should I do exactly to make it cool for you? May I can clone the repo again and copy all files and put them in one commit. (But in this case, I will delete this PR if I can, and I create another one.) |
|
I don't think you did, what you need to do is rebase on the main branch of this repository and then only add the gnome extension commits on top of it. |
…are no preferencesa, then hide it
7system7
force-pushed
the
gnome-extensions
branch
from
539e971 to
1cdc832
Compare
|
I made some changes. Is it OK? |
|
lgtm thanks, I will look at the extension soon |
|
It is finished. Sorry for the bunch of the commits. I always forgot something. But it is ready from now! |
|
Is it OK, or do you need something else? 😃 |
aurelleb
left a comment
aurelleb
left a comment
There was a problem hiding this comment.
these things aside, everything looks good to me! Sorry for the late review.
| actions={( | ||
| <ActionPanel> | ||
| <Action title="Reload Extensions" icon={Icon.RotateAntiClockwise} onAction={loadExtensions} /> | ||
| <Action title="Open Extension Manager" icon={Icon.AppWindow} onAction={() => open("gnome-extensions")} /> |
There was a problem hiding this comment.
I'm pretty sure this won't work, as open is meant to work with a URL or an app.
| ], | ||
| "preferences": [ | ||
| { | ||
| "name": "extensionManagerPath", |
There was a problem hiding this comment.
this doesn't seem to be used anywhere in the extension
2 participants
The original idea was to replace this GNOME extension.
This is a quiet new idea to get information about installed GNOME extensions. It has some other functions to handle them
etc.
Maybe, later, I would implement the installation/uninstallation feature from the official repo.