Feat(Chromium-Bookmarks): Added caching, Flatpak support, Favicons and performance/UX improvements#256
Open
JdotCarver wants to merge 22 commits intovicinaehq:mainfrom
Open
Feat(Chromium-Bookmarks): Added caching, Flatpak support, Favicons and performance/UX improvements#256JdotCarver wants to merge 22 commits intovicinaehq:mainfrom
JdotCarver wants to merge 22 commits intovicinaehq:mainfrom
Conversation
Jdot carver patch 1
Author
|
For some reason the postprocessing workflow is failing after modifying these unrelated files:
My PR only changes extensions/chromium-bookmarks and does not touch those. I have not touched those extensions. Should I do anything, or is the postprocessing workflow incompatible with fork PRs here? |
This is one of the problematic files. I have manually copy-pasted the current version in my fork, maybe this fixes it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Browser Support
Improved Logic
Quality of Life Improvements
I tried to test each feature extensively but if I have missed anything please notify me and I'll fix it.
Comparison
Search Results
Original
Improved
More pertinent search results.
Menu Items
Original
Improved
Interface is more unified. All actions have shortcuts.
You can directly jump into the settings to easily tweak.
Creating shortcuts is super convenient, everything pre-fills for you.
Preferences
Safe defaults built-in.
Any users from the previous version only has under the under-the-hood improvements and can opt-into the new features.
The Vicnae UI can only display a list of 10 elements, so the render limit only serves as an invisible way to boost speed for users, with further improvements at higher numbers. I personally have it set at 30, so I deemed the default of 100 to be more than reasonable.