fix: allow ESC to exit inline argument input focus#1004
Open
Razuer wants to merge 2 commits into
Open
Conversation
When an extension input field in the search bar is focused, pressing ESC now returns focus to the main search bar instead of closing the entire launcher window. This allows users to exit the argument input naturally using ESC while preserving the expected close behavior when focused on the main search bar.
When pressing ESC to exit an extension argument input, the typed values are now cleared. This ensures that clicking the item again triggers the argument focus behavior instead of immediately executing the command with stale input values.
Razuer
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Details
InlineQLineEdit(used inArgCompleter).Qt::Key_EscapeinInlineQLineEditand emits a signal instead of ignoring it (which previously caused the event to bubble up and close the window).ArgCompleterwhen ESC is pressed. This ensures that subsequent activation of the item triggers the "focus arguments" logic again, rather than the "execute command" logic (which runs when values are present).Usage