Skip to content

fix: Explicitly specify D-Bus signal signature for Gnome clipboard events #1036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rohankmr414 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Explicitly specify D-Bus signal signature for Gnome clipboard events #1036

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
extension-manager/runtime/node_modules
/cmake-build-debug
/.idea
/.vscode
/vgcore*
.env
.direnv
Expand Down
7 changes: 4 additions & 3 deletions vicinae/src/services/clipboard/gnome/gnome-clipboard-server.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,8 @@ bool GnomeClipboardServer::setupDBusConnection() {

// Connect to ClipboardChanged signal
// Signal signature: (ayss) = array of bytes, string, string
bool connected = m_bus.connect(DBUS_SERVICE, DBUS_PATH, DBUS_INTERFACE, "ClipboardChanged", this,
// Explicitly specify the D-Bus signature to ensure proper type matching in Qt6
bool connected = m_bus.connect(DBUS_SERVICE, DBUS_PATH, DBUS_INTERFACE, "ClipboardChanged", "ayss", this,
SLOT(handleClipboardChanged(QByteArray, QString, QString)));

if (!connected) {
Expand Down Expand Up @@ -140,8 +141,8 @@ void GnomeClipboardServer::cleanupDBusConnection() {
// Stop listening to clipboard changes
m_interface->call("StopListening");

// Disconnect from D-Bus signal
m_bus.disconnect(DBUS_SERVICE, DBUS_PATH, DBUS_INTERFACE, "ClipboardChanged", this,
// Disconnect from D-Bus signal (must use same signature as connect)
m_bus.disconnect(DBUS_SERVICE, DBUS_PATH, DBUS_INTERFACE, "ClipboardChanged", "ayss", this,
SLOT(handleClipboardChanged(QByteArray, QString, QString)));

delete m_interface;
Expand Down