feat(icons): Add Blank icon for invisible spacer#1107
Open
rattletat wants to merge 1 commit into
Open
Conversation
Add Icon.Blank — a transparent SVG that reserves icon space in list items without rendering anything visible. Useful for aligning text in lists where only some items have icons.
Contributor
|
I'm not a fan of this solution, I think it would be preferable to handle this case explicitly in the API (by treating a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
Icon.Blank— a transparent SVG that reserves icon space in list items without rendering anything visible.Use case: When a
Listhas a mix of items with and without icons, items without icons have their text shifted left, breaking alignment.Icon.Blankacts as an invisible spacer to keep text aligned.Changes:
src/server/icons/blank.svg— transparent 32x32 SVGsrc/typescript/api/src/api/icon.ts— enum entry