Skip to content

feat: option to keep pinned when clearing clipboard#1295

Open
andersmmg wants to merge 2 commits into
vicinaehq:mainfrom
andersmmg:keep-pinned-cb-option
Open

feat: option to keep pinned when clearing clipboard#1295
andersmmg wants to merge 2 commits into
vicinaehq:mainfrom
andersmmg:keep-pinned-cb-option

Conversation

@andersmmg
Copy link
Copy Markdown

Closes #1276

Comment thread src/server/src/services/clipboard/clipboard-service.cpp
@FredrikMWold
Copy link
Copy Markdown
Contributor

I tested this and it froze my computer and turned it into a yet engine for a few seconds 😆

Probably because i had like 40k entries and the loop that has to delete every single one individually now instead of just deleting the entire directory.

Maybe a solution could be a seperate data dir 'm_pinnedDataDir` Then store and move the entries when something is pinned or unpinned? This would allow for simpler cleanup

@SiriusCrain
Copy link
Copy Markdown
Contributor

@andersmmg I can investigate and fix perfomance issue if it's ok for you, and push it here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] "Clear Clipboard History" should preserve Pinned items

3 participants