fix: scroll viewport to focused window on Hyprland scrolling layout#1330
fix: scroll viewport to focused window on Hyprland scrolling layout#1330justindotdevv wants to merge 2 commits into
Conversation
|
any reason this is in draft state? looks good to me? |
|
doing testing on my machine to ensure it is working as intended |
|
Root cause was action timing rather than just the Hyprland IPC command. Vicinae was calling That also explains why cross-workspace looked better: Why previous iterations failed:
Final fix:
With that sequencing fixed, same-workspace switching now behaves correctly on Hyprland scrolling without the |
|
this workaround seems very convoluted to me. It looks like 9fb1f6d fixed this for some people? I'm assuming this didn't fix it for you? |
yea it did not fix it for me, this pr currently fixes it for me. this fix does touch a lot more files than i expected. after many iterations this is what i can provide unfortunately. |
|
out of curiosity i pulled the latest commit and tested it. it worked for me. traced the fix to 9ce527e. exclusive keyboard interactivity was preventing the compositor from cleanly handing off focus, so the scrolling layout's follow_focus never triggered. downgrading to OnDemand lets the focus transfer work properly. |
|
oh okay, interesting. I guess that could be considered an Hyprland bug no? If so I guess we can close this and maybe document the workaround? |
fixes #1329
On Hyprland's scrolling layout, the window switcher focuses the target window but doesn't scroll the viewport to reveal its column. This is because focuswindow only updates compositor-level focus without notifying the layout to adjust the viewport.
Fix: Batch dispatch layoutmsg fit active alongside focuswindow. This tells the scrolling layout to scroll the viewport to the focused column. It's a no-op on other layouts (dwindle, master)