Skip to content

feat: fanotify filesystem watch (last)#559

Draft
AntoineGS wants to merge 1 commit into
vicinaehq:mainfrom
AntoineGS:feat_fs-mark
Draft

feat: fanotify filesystem watch (last)#559
AntoineGS wants to merge 1 commit into
vicinaehq:mainfrom
AntoineGS:feat_fs-mark

Conversation

@AntoineGS
Copy link
Copy Markdown
Contributor

@AntoineGS AntoineGS commented Oct 27, 2025

This is still a work in progress and contains added logging/output and code to refactor but it works to give you an idea of what it could be like.

Fixes #538

Todos

  • Cleanup logging
  • Add mentions for BTRFS in the doc or UI, possibly a warning when detected

@quadratech188
Copy link
Copy Markdown
Contributor

This looks more like an e-dant/watcher (the external library that provides watcher.hpp) pull request rather than a vicinae pull request, so maybe we should consider contributing to that instead?

@quadratech188
Copy link
Copy Markdown
Contributor

quadratech188 commented Oct 28, 2025

Technically we could have our own version, but then updating the library would be a nightmare

@AntoineGS
Copy link
Copy Markdown
Contributor Author

😲 I had no idea this was an external dep, my bad.
Yeah you are right, I will see about upstreaming the changes and report back on how that goes.

@aurelleb
Copy link
Copy Markdown
Contributor

aurelleb commented Oct 28, 2025

I think it's okay to make local edits to our watcher.hpp to suit our use cases, and propose a PR upstream if they are interested.

@AntoineGS AntoineGS force-pushed the feat_fs-mark branch 3 times, most recently from 80c6db9 to 0522edd Compare October 31, 2025 19:36
@AntoineGS
Copy link
Copy Markdown
Contributor Author

AntoineGS commented Oct 31, 2025

I am starting to get conflicts in between branches (I try to keep features/fixes separate as much as possible).
Do you have any objections that I branch each PR off another PR and I number them in the order that they should be merged to keep changes separate?

@AntoineGS AntoineGS force-pushed the feat_fs-mark branch 3 times, most recently from 08ed2db to 2d7ab33 Compare October 31, 2025 20:59
@AntoineGS AntoineGS changed the title feat: fanotify filesystem watch feat: fanotify filesystem watch (4) Oct 31, 2025
@AntoineGS AntoineGS changed the title feat: fanotify filesystem watch (4) feat: fanotify filesystem watch (last) Nov 1, 2025
@AntoineGS AntoineGS force-pushed the feat_fs-mark branch 6 times, most recently from 68e9eaa to 72b958f Compare November 5, 2025 14:06
@aurelleb aurelleb force-pushed the main branch 2 times, most recently from 4b8065c to c26ad02 Compare November 13, 2025 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for fanotify's FAN_MARK_FILESYSTEM

3 participants