-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Miketrahearn/1492 alarm indicator prototype #1808
base: main
Are you sure you want to change the base?
Miketrahearn/1492 alarm indicator prototype #1808
Conversation
ba23fcc
to
bc325b0
Compare
Updated the filtering logic and visual appearance according to Victron requirements. |
0ab99f6
to
8ae761b
Compare
TODO: review all cases where we might be using the /Alarm or /Alert values (0 or 1) as these are proposed to be depreciated for Gui-v2 in favour of additional paths describing the counters in more detail.* Global.notifications.alarm is used:
Global.notifications.alert is used:
|
TODO: replace "acknowledgeAll" with "silenceAll" (Notifications.qml /AcknowledgeAll) and also the Notification.qml /Acknowledged field > /Silenced |
945afa7
to
4b03540
Compare
@ReinvdZee this branch has been fully updated to adhere to the proposed UI and backend API changes for Notifications and may be tested with matching prototype firmware. Couple of outstanding questions regarding the text on some controls now we are moving away from the the term "alert"...
What are your thoughts on these suggestions or just leave them as they are (the logic behind them is updated to the new API), as we are just talking about visual text updates. Additionally, the previous behaviour for the two "silence" buttons mentioned above were that they stay visible once clicked if the alarm / notifications that are silenced are still active. Once they go inactive the buttons then disappear. |
deec66e
to
1319a1e
Compare
1319a1e
to
bad9f56
Compare
Update logic for Notification indicator in Nav Bar Update implementation for Status Bar silencing buttons Refactor NotificationModel to handle all Notifications Add Filter/Sorting of NotificationModel for all roles Ensure VeQuickItem write-back for /Active and /Silenced Rework the Mock implementation to use the new API Fix Binding Loop in the Notification delegate Part of #1492
eba6bba
to
2af1266
Compare
This is a prototype of the new Alarms UI and API