Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miketrahearn/1492 alarm indicator prototype #1808

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

MikeTrahearn-Qinetic
Copy link
Contributor

@MikeTrahearn-Qinetic MikeTrahearn-Qinetic commented Dec 19, 2024

This is a prototype of the new Alarms UI and API

@MikeTrahearn-Qinetic MikeTrahearn-Qinetic force-pushed the miketrahearn/1492-alarm-indicator-prototype branch from ba23fcc to bc325b0 Compare December 23, 2024 01:16
@MikeTrahearn-Qinetic
Copy link
Contributor Author

Updated the filtering logic and visual appearance according to Victron requirements.

@ReinvdZee ReinvdZee marked this pull request as ready for review December 23, 2024 15:20
@MikeTrahearn-Qinetic MikeTrahearn-Qinetic self-assigned this Dec 26, 2024
@MikeTrahearn-Qinetic MikeTrahearn-Qinetic marked this pull request as draft December 27, 2024 00:00
@MikeTrahearn-Qinetic MikeTrahearn-Qinetic force-pushed the miketrahearn/1492-alarm-indicator-prototype branch 3 times, most recently from 0ab99f6 to 8ae761b Compare January 13, 2025 01:13
@MikeTrahearn-Qinetic
Copy link
Contributor Author

MikeTrahearn-Qinetic commented Jan 13, 2025

TODO: review all cases where we might be using the /Alarm or /Alert values (0 or 1) as these are proposed to be depreciated for Gui-v2 in favour of additional paths describing the counters in more detail.*
Search: Global.notifications.alarm or Global.notifications.alert. We may have to use a different properties for these going forward.

Global.notifications.alarm is used:

  • on startup (MainView.qml) once the swipeViewLoader has loaded on which the notifications page will show if Global.notifications.alarm is 1. Do we now mean numberOfActiveAlarms or do we also need to include numberOfActiveWarnings too?
  • in StatusBar.qml to determine if the "Silence alarm" should be enabled or not. Should we be using Global.notifications.numberOfActiveAlarms now?

Global.notifications.alert is used:

  • in the NavBar on the notification bell icon, to determine if the red dot should be shown or not. This isn't mentioned in the UI spec concerning the relevant changes.
  • in StatusBar.qml to determine if the "Acknowledge alerts" button is enabled. Should we be using Global.notifications.numberOfActiveWarnings now?

@MikeTrahearn-Qinetic
Copy link
Contributor Author

MikeTrahearn-Qinetic commented Jan 13, 2025

TODO: replace "acknowledgeAll" with "silenceAll" (Notifications.qml /AcknowledgeAll) and also the Notification.qml /Acknowledged field > /Silenced
We should consider if we need to change the wording (translations, translation ids) elsewhere for example in the StatusBar "Acknowledge alerts" and "Silence Alarm" buttons

@MikeTrahearn-Qinetic MikeTrahearn-Qinetic force-pushed the miketrahearn/1492-alarm-indicator-prototype branch 7 times, most recently from 945afa7 to 4b03540 Compare January 16, 2025 04:41
@MikeTrahearn-Qinetic
Copy link
Contributor Author

MikeTrahearn-Qinetic commented Jan 16, 2025

@ReinvdZee this branch has been fully updated to adhere to the proposed UI and backend API changes for Notifications and may be tested with matching prototype firmware.

Couple of outstanding questions regarding the text on some controls now we are moving away from the the term "alert"...

  • StatusBar "Silence alarm" button: replace translation with "Silence Alarms" (pluralise)
  • StatusBar "Acknowledge alerts" button: replace translation with "Acknowledge notifications"?
  • NotificationsPage: "No current alerts": replace translation with "No current notifications"?

What are your thoughts on these suggestions or just leave them as they are (the logic behind them is updated to the new API), as we are just talking about visual text updates.

Additionally, the previous behaviour for the two "silence" buttons mentioned above were that they stay visible once clicked if the alarm / notifications that are silenced are still active. Once they go inactive the buttons then disappear.
This follows the same reasoning as to why a silenced notification stays in the top view while it is still active before dropping into the history view below.
However this means that you will have a button that you can press multiple times over and it only does anything the first time. Should they disappear as soon as they are pressed? This is an easy fix.

@MikeTrahearn-Qinetic MikeTrahearn-Qinetic force-pushed the miketrahearn/1492-alarm-indicator-prototype branch 6 times, most recently from deec66e to 1319a1e Compare January 23, 2025 01:44
@MikeTrahearn-Qinetic MikeTrahearn-Qinetic force-pushed the miketrahearn/1492-alarm-indicator-prototype branch from 1319a1e to bad9f56 Compare January 24, 2025 05:31
Update logic for Notification indicator in Nav Bar
Update implementation for Status Bar silencing buttons
Refactor NotificationModel to handle all Notifications
Add Filter/Sorting of NotificationModel for all roles
Ensure VeQuickItem write-back for /Active and /Silenced
Rework the Mock implementation to use the new API
Fix Binding Loop in the Notification delegate

Part of #1492
@MikeTrahearn-Qinetic MikeTrahearn-Qinetic force-pushed the miketrahearn/1492-alarm-indicator-prototype branch from eba6bba to 2af1266 Compare January 24, 2025 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant