-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use opaque colors #689
base: main
Are you sure you want to change the base?
Use opaque colors #689
Conversation
9f0fe9d
to
153b592
Compare
Q_OBJECT | ||
QML_NAMED_ELEMENT(Theme) | ||
QML_SINGLETON | ||
Q_OBJECT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tabs look wonky
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code which forms part of the output needs tabs, whereas the python code needs spaces. Hence the discrepancy. What is in the PR is correct, I believe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Putting this on hold for now - asked Serj instead if he could just provide opaque colours for all elements. Hopefully he agrees. If not, we can go down this PR path (and maybe provide a |
153b592
to
3846f17
Compare
Serj provided some opaque colours, but they didn't match the existing colour scheme (it might be intentional or might be a mistake) and a variety of colours were missing, unfortunately. I've added a set of colours which match the previous design, and covers all of the colours we use in our code. I have asked Serj whether these colours need any adjustments. |
3dc72d6
to
7fa0639
Compare
Alpha blending is expensive. Reducing alpha blending by using opaque colors reduces GPU work, and thus `swap` time.
7fa0639
to
6f599b2
Compare
The ability to define opaque colors is dependent on how well defined the colors are in the Figma Design System. |
Alpha blending is expensive. Reducing alpha blending by using opaque colors reduces GPU work, and thus
swap
time.