feat(diagnostics): check if WebAssembly is supported #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hey @mman , you wrote:
but the gui-v2 doesn't work on a Simrad, as reported in the gui-v2 issue by Rein. So can we conclude that this would have been nice but doesn't / too complex, we need to come up with something else; especially to prevent this becoming a blocker for releasing gui-v2 into Venus OS as default? |
That would mean that the check is not sufficient and unreliable. Too bad. I will get in touch with Rein to see what more needs to be done to prevent false success result. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #389 in that it adds a simple check for
WebAssemblyandWebAssembly.instantiateand displays the result on a Diagnostics page for now. It seems to correctly detect presence of WebAssembly on Raymarine and Simrad, and reports false for Furuno and Garmin I tested.Update: the check is not sufficient as gui-v2 does not start anyway and gets stuck at Loading screen...