Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add liveSyncOnStallIncrease config option #6455

Merged
merged 6 commits into from
Jun 28, 2024

Conversation

vk342
Copy link
Contributor

@vk342 vk342 commented May 28, 2024

This PR will...

add a new configuration option liveSyncOnStallIncrease to replace the constant currently used by LatencyController:

const liveSyncOnStallIncrease = 1.0;

Why is this Pull Request needed?

Currently each time the player encounters a stall, targetLatency is incremented by 1 second, see

const liveSyncOnStallIncrease = 1.0;
return (
targetLatency +
Math.min(
this.stallCount * liveSyncOnStallIncrease,
maxLiveSyncOnStallIncrease,
)

This PR replaces local const liveSyncOnStallIncrease = 1.0 with a value coming from hls.js config, as suggested here.

Are there any points in the code the reviewer needs to double check?

Resolves issues:

Checklist

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • API or design changes are documented in API.md

robwalch
robwalch previously approved these changes May 28, 2024
@robwalch robwalch added this to the 1.6.0 milestone May 28, 2024
@robwalch robwalch changed the title add liveSyncOnStallIncrease config option Add liveSyncOnStallIncrease config option May 28, 2024
@robwalch robwalch merged commit 8555f8b into video-dev:master Jun 28, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants