added ability to override error-controller error handling via HlsConfig #7658
+97
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robwalch
reviewed
Nov 19, 2025
github-project-automation
bot
moved this to Top priorities
in HLS.js Release Planning and Backlog
robwalch
moved this from Top priorities
to Nice to have
in HLS.js Release Planning and Backlog
robwalch
reviewed
Jan 7, 2026
| if (data.fatal) { | ||
| const hls = this.hls; | ||
| // If the error is handled by onErrorHandler or is fatal, do not proceed with error recovery | ||
| if (hls.config.onErrorHandler?.(data) || data.fatal) { |
Collaborator
There was a problem hiding this comment.
We might not want to start marking actions as resolved when fatal. To keep the handling of fatal errors the same, this PR should add a new block:
Suggested change
| if (hls.config.onErrorHandler?.(data) || data.fatal) { | |
| if (data.fatal) { | |
| return; | |
| } | |
| if (hls.config.onErrorHandler?.(data)) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will allow for error-controller to defer handling of errors via HlsConfig.
Why is this Pull Request needed?
In certain cases, you may not want hls.js to raise a fatal when an error occurs OR you would like to handle an error manually. An example would be if WebVTT subtitles are in use and the player enters an adbreak (where no subtitle's exist) OR there is a CDN issue where WebVTT files are unavailable, the developer may want playback to continue rather than raising a fatal error.
Are there any points in the code the reviewer needs to double check?
Ensure that callback functions & documentation is clear.
Resolves issues:
N/A => I will create an issue depending on feedback to this draft PR.
Checklist