Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow src attribute to work #5762

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: allow src attribute to work #5762

wants to merge 3 commits into from

Conversation

gkatsev
Copy link
Member

@gkatsev gkatsev commented Jan 22, 2019 •
edited
Loading

If we are loading a new tech and sources array is empty and we have a src option from the src attribute, set that to be a sources array of just the string.

This helps a lot with #4851 and may be the last fix.

Fixes #5701

@gkatsev gkatsev added needs: LGTM Needs one or more additional approvals needs: testing labels Jan 22, 2019
@gkatsev
Copy link
Member Author

gkatsev commented Jan 22, 2019

Looks like needs some more attention, particularly wrt tests.

@gkatsev gkatsev added needs: updates and removed needs: LGTM Needs one or more additional approvals needs: testing labels Jan 22, 2019
@gkatsev gkatsev mentioned this pull request Feb 11, 2019
Closed
7 tasks
@gkatsev
Copy link
Member Author

gkatsev commented Feb 11, 2019

Going to leave this open for now, if someone has time to look at why it's failing, that'll be great.

@misteroneill
Copy link
Member

Yeah, it appears to be breaking sourceset tests.

@stale
Copy link

stale bot commented Apr 12, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the outdated Things closed automatically by stalebot label Apr 12, 2019
@gkatsev gkatsev removed the outdated Things closed automatically by stalebot label Apr 12, 2019
@gkatsev gkatsev mentioned this pull request May 28, 2019
Closed
@stale
Copy link

stale bot commented Jun 18, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the outdated Things closed automatically by stalebot label Jun 18, 2019
@gkatsev gkatsev removed outdated Things closed automatically by stalebot labels Jun 20, 2019
@stale
Copy link

stale bot commented Aug 19, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the outdated Things closed automatically by stalebot label Aug 19, 2019
@gkatsev gkatsev removed the outdated Things closed automatically by stalebot label Aug 19, 2019
@stale
Copy link

stale bot commented Oct 18, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the outdated Things closed automatically by stalebot label Oct 18, 2019
@stale stale bot closed this Oct 25, 2019
@gkatsev gkatsev reopened this Nov 21, 2019
@stale stale bot removed the outdated Things closed automatically by stalebot label Nov 21, 2019
@stale
Copy link

stale bot commented Jan 21, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the outdated Things closed automatically by stalebot label Jan 21, 2020
@gkatsev gkatsev removed the outdated Things closed automatically by stalebot label Jan 27, 2020
@stale
Copy link

stale bot commented Mar 21, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the outdated Things closed automatically by stalebot label Mar 21, 2020
@gkatsev gkatsev removed the outdated Things closed automatically by stalebot label Mar 24, 2020
@stale
Copy link

stale bot commented May 20, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the outdated Things closed automatically by stalebot label May 20, 2020
@stale stale bot closed this May 30, 2020
@gkatsev gkatsev reopened this Aug 6, 2020
@stale stale bot removed the outdated Things closed automatically by stalebot label Aug 6, 2020
@AsengRossi46 AsengRossi46 mentioned this pull request Sep 9, 2020
Closed
@stale
Copy link

stale bot commented Oct 10, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the outdated Things closed automatically by stalebot label Oct 10, 2020
@gkatsev gkatsev added pinned Things that stalebot shouldn't close automatically and removed outdated Things closed automatically by stalebot labels Oct 10, 2020
@rwlaschin
Copy link

Has this been fixed? Looks like no... can this be reopened?

@gkatsev
Copy link
Member Author

gkatsev commented Dec 13, 2020

This is still open. Unfortunately, I haven't had the time to come back to it yet.

@gkatsev gkatsev mentioned this pull request Jan 12, 2021
Closed
@misteroneill misteroneill changed the base branch from master to main May 19, 2022 14:10
@misteroneill misteroneill added the patch This PR can be added to a patch release. label May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs: updates patch This PR can be added to a patch release. pinned Things that stalebot shouldn't close automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gkatsev @misteroneill @rwlaschin @BVFernandesFEUP