Display time tooltip for mobile when sliding#7598
Display time tooltip for mobile when sliding#7598Chocobozzz wants to merge 1 commit intovideojs:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7598 +/- ##
==========================================
- Coverage 80.24% 80.24% -0.01%
==========================================
Files 116 116
Lines 7325 7324 -1
Branches 1771 1770 -1
==========================================
- Hits 5878 5877 -1
Misses 1447 1447 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
bump |
|
The current behaviour to hide was added in #4185, in 2017. On a modern Android Chrome the tooltips look fine with this PR, but I'm not sure what problems needed to be avoided back then. |
|
It was turned off because the tooltips definitely weren't working right back then on touch (mobile) devices. |
Do you remember with what OS/device? I could try to test this PR on them using browser stack |
|
Unfortunately, I do not remember. I'm also not sure that testing via browserstack would be reliable enough here. |
|
Any updates on this? |
|
The feature is available since v8.21.0: 57d6ab6 |
Hi :)
Description
Display time tooltip when sliding on mobile. Without this, it's difficult to move to the desired timestamp on android/ios.
Specific Changes proposed
Enable
timeTooltipfor mobile and adapt CSS to always display it when sliding.Requirements Checklist