-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adds a transient button component #8629
Open
mister-ben
wants to merge
12
commits into
videojs:main
Choose a base branch
from
mister-ben:transient-button
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
37e6cc9
to
e491321
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8629 +/- ##
==========================================
+ Coverage 83.01% 83.06% +0.05%
==========================================
Files 119 120 +1
Lines 7993 8021 +28
Branches 1923 1924 +1
==========================================
+ Hits 6635 6663 +28
Misses 1358 1358 ☔ View full report in Codecov by Sentry. |
ae74816
to
015f17b
Compare
amtins
reviewed
Mar 6, 2024
amtins
reviewed
Mar 6, 2024
amtins
reviewed
Mar 6, 2024
amtins
reviewed
Mar 6, 2024
a40a984
to
ebebbde
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a
TransientButton
component for the types of button that are shown on top of the video briefly during playback and reappear when there is user activity. e.g. Unmute buttons, skip intro. It aims is to be a generic button type to be extended. Some basic styles are provided but kept light to not complicate customisation.It's important to insert a transient button before the control bar for the tab order to make sense.
Optionally takes focus when shown.
Specific Changes proposed
Adds
TransientButton
component.Requirements Checklist
npm run docs:api
to error