feat: Allow three.js renderer options to be configurable #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Smidgens
changed the title
5 tasks
mister-ben
changed the title
mister-ben
approved these changes
Dec 18, 2023
WCPetersen
added a commit
to WCPetersen/videojs-vr
that referenced
this pull request
Feb 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the videojs-vr plugin instantiates a three.js WebGL Renderer, it uses hardcoded values. This change will allow users to override these defaults. This would be beneficial for performance reasons, such as disabling antialiasing or tweaking power preference.
Specific Changes proposed
defaultsoptions object inplugin.js, there is now a property calledthreeRendererOptionscontaining values previously hardcoded.options_.threeRendererOptionswhich is a merged result of the default values and those supplied by the user (if any), similar to how Omnitone is set up.