chore: Swap webvr to webxr polyfill packages #273

kevleyski · 2022-12-20T03:25:13Z

Description

Fixes #216 (WebXR support)

Specific Changes proposed

For devices that support WebXR use that
Add iOS device orientation permission check on entering 360 (note ESLint workaround as this is iOS Safari specfic)
Fall back to original WebVR polyfill if navigator.xr not available after initialising WebXR polyfill

Requirements Checklist

Feature implemented / Bug fixed
If necessary, more likely in a feature request than a bug fix
- Unit Tests updated or fixed
- Docs/guides updated
Reviewed by Two Core Contributors

…w Device API is more likely the better thing to do though

WebVR to WebXR

[KJSL] Swap webvr ro webxr polyfill packages

[KJSL] Add WebXR immersive VR support

chore: Swap webvr ro webxr polyfill packages

…olyfill if webxr immersive is not available)

chore: Swap webvr ro webxr polyfill packages (continue to use webvr p…

… operation to play/pause and exit VR/AR session)

chore: Swap webvr for webxr polyfill packages (adding basic controller…

…k on entering 360)

chore: Swap webvr ro webxr polyfill packages

…k on entering 360)

chore: Swap webvr to webxr polyfill packages

kevleyski · 2022-12-20T03:52:20Z

Had planned to add thinks like thumb stick controls scrubbing rate maybe and throw a TV not your AR wall - but then those can be a separate issue items

This is more a quick fix to get the player playing immersive VR

gkatsev

OMG, thank you so much for this! Been highly requested for sure.

Had a couple of questions.

CONTRIBUTING.md

CHANGELOG.md

package.json

src/big-vr-play-button.js

gkatsev · 2022-12-20T16:30:45Z

src/plugin.js

@@ -1,6 +1,8 @@
+import 'babel-polyfill';


What is babel-polyfill needed for here? Since this is a library, we generally prefer not including polyfills, requesting users include it on their page themselves.
Also, should this be using @babel/polyfill as it's newer?

This seemed to be a dependency of webxr polyfill - I'll recheck

Seems like it isn't required https://github.com/immersive-web/webxr-polyfill#browser-support

I think we should make a note of it in the README, but otherwise leave it out of the bundle.

Ok so I tried pulling it out this results in the WebXR sessions not starting because there is some regenerator code not generated without babel-polyfill
I encourage other to help remove it if its a concern, I'm out of cycles today

going to "unresolve" this just so that it doesn't get lost, but I don't think it's a blocker.

gkatsev · 2022-12-20T16:31:30Z

src/plugin.js

+    // Detect WebXR is supported
+    if (window.navigator.xr) {


src/plugin.js

gkatsev · 2022-12-20T16:35:07Z

src/plugin.js

+    if (window.navigator.xr) {
+      this.log('WebXR is supported');
+      window.navigator.xr.isSessionSupported('immersive-vr').then((supportsImmersiveVR) => {
+        if (supportsImmersiveVR) {


if this is false should we try and fall back to the WebVRPolyfill? Or does it happen automatically? A bit hard to understand since it's asynchronous.

Yeah I went through a few permutations of that - after testing it seemed to not really matter
Then again could be getting lucky in timing each time

gkatsev · 2022-12-20T16:36:12Z

src/plugin.js

+    }
+
+    // No WebXR support fall back to using WebVR polyfill
+    if (!hasWebXR) {


wouldn't this always get set up regardless of whether webXR is available? Since hasWebXR will always be false here as it hasn't been set to true in the promise above.

Co-authored-by: Gary Katsevman <[email protected]>

src/plugin.js

… work when there is no webxr pluging)

part revert to allow webvr to still work when there is no webxr plug-in

three.js version revert back to v129 as 130 breaks renderer.getSize

chore: Swap webvr for webxr polyfill packages

… fall back if no WebXR)

chore: Swap webvr for webxr polyfill packages (PR fix ups - fix up VR fall back if no WebXR)

…0 Left/Right)

chore: Swap webvr for webxr polyfill packages (PR fix ups - fix up 180 Left/Right)

chore: Swap webvr for webxr polyfill packages (PR fix ups - cubemap)

…etter precision for headsets)

chore: Swap webvr for webxr polyfill packages (PR fix ups - cubemap better precision for headsets)

* chore: Swap webvr for webxr polyfill packages (PR fix ups - UI)

kevleyski · 2023-07-06T04:30:07Z

Not entirely sure where package-lock.json came from
(anyhow my local merge was ok without conflicts)

mister-ben · 2023-12-01T10:04:53Z

It's a shame this stalled, would be great to get all this work in. Is it just package-lock that needs to be fixed up?

mister-ben · 2023-12-05T16:59:39Z

I've a branch here with these changes merged onto main, https://github.com/mister-ben/videojs-vr/tree/from-metacdn

Kevin Staunton-Lambert and others added 25 commits December 2, 2022 13:51

Updating node-sass version (to remove python2 dependency)

d742fd1

Husky update

d3fba93

[KJSL] Swap webvr ro webxr polyfill packages

139f797

Example of having both polyfills - rewritting plugin.js to use the ne…

a46b98d

…w Device API is more likely the better thing to do though

[KJSL] Swap webvr ro webxr polyfill packages

dc28b05

Merge pull request #1 from kevleyski/main

f41dc2a

WebVR to WebXR

[KJSL] Swap webvr ro webxr polyfill packages

dbc1073

[KJSL] Swap webvr ro webxr polyfill packages

cd30806

Merge pull request #2 from kevleyski/main

eecdbba

[KJSL] Swap webvr ro webxr polyfill packages

[KJSL] Swap webvr ro webxr polyfill packages

d6821ab

Merge pull request #3 from kevleyski/main

842abed

[KJSL] Swap webvr ro webxr polyfill packages

[KJSL] Swap webvr ro webxr polyfill packages

6de443d

[KJSL] Swap webvr ro webxr polyfill packages

b318d28

[KJSL] Swap webvr ro webxr polyfill packages

6d4ff0a

Merge pull request #4 from kevleyski/main

e02ce1d

[KJSL] Add WebXR immersive VR support

chore: Swap webvr ro webxr polyfill packages

70a1611

Merge pull request #5 from kevleyski/main

e0d1c48

chore: Swap webvr ro webxr polyfill packages

chore: Swap webvr ro webxr polyfill packages (continue to use webvr p…

36e7cdc

…olyfill if webxr immersive is not available)

Merge pull request #6 from kevleyski/main

c8330f7

chore: Swap webvr ro webxr polyfill packages (continue to use webvr p…

chore: Swap webvr ro webxr polyfill packages (adding basic controller…

56ad5f3

… operation to play/pause and exit VR/AR session)

Merge pull request #7 from kevleyski/main

a8d1459

chore: Swap webvr for webxr polyfill packages (adding basic controller…

chore: Swap webvr ro webxr polyfill packages (add iOS permission chec…

856a183

…k on entering 360)

Merge pull request #8 from kevleyski/main

8d88ec5

chore: Swap webvr ro webxr polyfill packages

chore: Swap webvr ro webxr polyfill packages (add iOS permission chec…

7c0c62b

…k on entering 360)

Merge pull request #9 from kevleyski/main

46c7207

chore: Swap webvr to webxr polyfill packages

gkatsev reviewed Dec 20, 2022

View reviewed changes

kevleyski and others added 2 commits December 21, 2022 04:01

Update src/big-vr-play-button.js

7bf68a5

Co-authored-by: Gary Katsevman <[email protected]>

Update src/plugin.js

1cc47ef

Co-authored-by: Gary Katsevman <[email protected]>

gkatsev reviewed Dec 20, 2022

View reviewed changes

src/plugin.js Outdated Show resolved Hide resolved

kevleyski added 10 commits January 27, 2023 20:48

three.js version API differences (part revert to allow webvr to still…

8adb558

… work when there is no webxr pluging)

Merge pull request #19 from kevleyski/main

3264b5e

part revert to allow webvr to still work when there is no webxr plug-in

three.js version revert back to v129 as 130 breaks renderer.getSize

f8ea3cb

Merge pull request #20 from kevleyski/main

c9f5903

three.js version revert back to v129 as 130 breaks renderer.getSize

cubemap verticies

466267b

fix up 180 mono

da9c89c

Merge pull request #21 from kevleyski/main

c3b9b4f

chore: Swap webvr for webxr polyfill packages

Move to latest THREE.js (0.149.0)

c4bd610

Use latest THREE.js

a4c12ac

Merge pull request #22 from kevleyski/main

3786a9d

chore: Swap webvr for webxr polyfill packages

gkatsev mentioned this pull request Jan 27, 2023

chore: update build tooling to drop older browser support #276

Merged

Kevin Staunton-Lambert and others added 10 commits January 30, 2023 10:50

chore: Swap webvr for webxr polyfill packages (PR fix ups - fix up VR…

5943617

… fall back if no WebXR)

Merge pull request #23 from kevleyski/main

70c5f29

chore: Swap webvr for webxr polyfill packages (PR fix ups - fix up VR fall back if no WebXR)

chore: Swap webvr for webxr polyfill packages (PR fix ups - fix up 18…

37fe825

…0 Left/Right)

Merge pull request #24 from kevleyski/main

e444322

chore: Swap webvr for webxr polyfill packages (PR fix ups - fix up 180 Left/Right)

chore: Swap webvr for webxr polyfill packages (PR fix ups - cubemap)

d890f20

chore: Swap webvr for webxr polyfill packages (PR fix ups - cubemap)

89ab083

chore: Swap webvr for webxr polyfill packages (PR fix ups - cubemap)

dc27ea8

Merge pull request #25 from kevleyski/main

cd05e47

chore: Swap webvr for webxr polyfill packages (PR fix ups - cubemap)

chore: Swap webvr for webxr polyfill packages (PR fix ups - cubemap b…

a2b1aa0

…etter precision for headsets)

Merge pull request #26 from kevleyski/main

ad1b413

chore: Swap webvr for webxr polyfill packages (PR fix ups - cubemap better precision for headsets)

alex-barstow changed the title ~~chore: Swap webvr ro webxr polyfill packages~~ chore: Swap webvr to webxr polyfill packages Feb 1, 2023

kevleyski added 4 commits March 31, 2023 16:15

chore: Swap webvr for webxr polyfill packages (PR fix ups - UI) (#27)

c58338c

* chore: Swap webvr for webxr polyfill packages (PR fix ups - UI)

(more tests/examples)

4a58148

(more tests/examples)

48fd17b

(fix up PR videojs#273 merge)

46fd3b1

mister-ben mentioned this pull request Dec 8, 2023

feat: Update to WebXR #285

Draft

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: Swap webvr to webxr polyfill packages #273

chore: Swap webvr to webxr polyfill packages #273

kevleyski commented Dec 20, 2022 •

edited

Loading

kevleyski commented Dec 20, 2022

gkatsev left a comment

gkatsev Dec 20, 2022

kevleyski Dec 20, 2022

gkatsev Dec 20, 2022

kevleyski Dec 21, 2022

gkatsev Dec 21, 2022

gkatsev Dec 20, 2022

gkatsev Dec 20, 2022

kevleyski Dec 20, 2022

gkatsev Dec 20, 2022

kevleyski commented Jul 6, 2023

mister-ben commented Dec 1, 2023

mister-ben commented Dec 5, 2023

chore: Swap webvr to webxr polyfill packages #273

Are you sure you want to change the base?

chore: Swap webvr to webxr polyfill packages #273

Conversation

kevleyski commented Dec 20, 2022 • edited Loading

Description

Specific Changes proposed

Requirements Checklist

kevleyski commented Dec 20, 2022

gkatsev left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kevleyski commented Jul 6, 2023

mister-ben commented Dec 1, 2023

mister-ben commented Dec 5, 2023

kevleyski commented Dec 20, 2022 •

edited

Loading