This repository has been archived by the owner on Apr 1, 2023. It is now read-only.
Rust integration #108
Closed
Rust integration #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the new Rust implementation, VLC suport is dropped. This is mainly because it doesn't work well with automatic synchronization because it's not precise enough. QtWebEngine is also dropped in place of a small web server in the Rust implementation that asks the user to log in, and automatically obtains the authentication information. This considerably reduces the size and complexity of Vidify, since shipping an entire webkit is excessive for the small usage it had, and anyone has a web browser around anyway. Vidify is now less modular as well, which means that it's much easier to distribute and install. It will from now on include support for all APIs and Players, optionally being able to include new ones manually.
marioortizmanero
force-pushed
the
rust-integration
branch
from
4b08416 to
df73675
Compare
marioortizmanero
force-pushed
the
rust-integration
branch
from
77b260e to
e2b9f36
Compare
marioortizmanero
force-pushed
the
rust-integration
branch
from
e2b9f36 to
3cae901
Compare
It's not worth it re-writing *everything* in Rust. I'll just use a couple of things like the config and resource management, and audiosync will be what's actually written in Rust.
…/pyo3-0.13.0 Bump pyo3 from 0.12.4 to 0.13.0
Bumps [pyo3](https://github.com/pyo3/pyo3) from 0.13.0 to 0.13.1. - [Release notes](https://github.com/pyo3/pyo3/releases) - [Changelog](https://github.com/PyO3/pyo3/blob/master/CHANGELOG.md) - [Commits](PyO3/pyo3@v0.13.0...v0.13.1) Signed-off-by: dependabot-preview[bot] <[email protected]>
…/pyo3-0.13.1 Bump pyo3 from 0.13.0 to 0.13.1
Bumps [serde](https://github.com/serde-rs/serde) from 1.0.118 to 1.0.123. - [Release notes](https://github.com/serde-rs/serde/releases) - [Commits](serde-rs/serde@v1.0.118...v1.0.123) Signed-off-by: dependabot-preview[bot] <[email protected]>
Bumps [log](https://github.com/rust-lang/log) from 0.4.11 to 0.4.14. - [Release notes](https://github.com/rust-lang/log/releases) - [Changelog](https://github.com/rust-lang/log/blob/master/CHANGELOG.md) - [Commits](rust-lang/log@0.4.11...0.4.14) Signed-off-by: dependabot-preview[bot] <[email protected]>
Bumps [libpulse-binding](https://github.com/jnqnfe/pulse-binding-rust) from 2.22.0 to 2.23.0. - [Release notes](https://github.com/jnqnfe/pulse-binding-rust/releases) - [Commits](jnqnfe/pulse-binding-rust@v2.22.0...v2.23.0) Signed-off-by: dependabot-preview[bot] <[email protected]>
Bumps [env_logger](https://github.com/env-logger-rs/env_logger) from 0.8.2 to 0.8.3. - [Release notes](https://github.com/env-logger-rs/env_logger/releases) - [Changelog](https://github.com/env-logger-rs/env_logger/blob/master/CHANGELOG.md) - [Commits](rust-cli/env_logger@v0.8.2...v0.8.3) Signed-off-by: dependabot-preview[bot] <[email protected]>
Bumps [pyo3](https://github.com/pyo3/pyo3) from 0.13.1 to 0.13.2. - [Release notes](https://github.com/pyo3/pyo3/releases) - [Changelog](https://github.com/PyO3/pyo3/blob/master/CHANGELOG.md) - [Commits](PyO3/pyo3@v0.13.1...v0.13.2) Signed-off-by: dependabot-preview[bot] <[email protected]>
Bumps [thiserror](https://github.com/dtolnay/thiserror) from 1.0.22 to 1.0.24. - [Release notes](https://github.com/dtolnay/thiserror/releases) - [Commits](dtolnay/thiserror@1.0.22...1.0.24) Signed-off-by: dependabot-preview[bot] <[email protected]>
…/thiserror-1.0.24 Bump thiserror from 1.0.22 to 1.0.24
…/pyo3-0.13.2 Bump pyo3 from 0.13.1 to 0.13.2
…/env_logger-0.8.3 Bump env_logger from 0.8.2 to 0.8.3
…/libpulse-binding-2.23.0 Bump libpulse-binding from 2.22.0 to 2.23.0
…/log-0.4.14 Bump log from 0.4.11 to 0.4.14
…/serde-1.0.123 Bump serde from 1.0.118 to 1.0.123
Bumps [simplelog](https://github.com/drakulix/simplelog.rs) from 0.9.0 to 0.10.0. - [Release notes](https://github.com/drakulix/simplelog.rs/releases) - [Changelog](https://github.com/Drakulix/simplelog.rs/blob/master/CHANGELOG.md) - [Commits](Drakulix/simplelog.rs@v0.9.0...v0.10.0) Signed-off-by: dependabot-preview[bot] <[email protected]>
…/simplelog-0.10.0 Bump simplelog from 0.9.0 to 0.10.0
Bumps [serde](https://github.com/serde-rs/serde) from 1.0.123 to 1.0.125. - [Release notes](https://github.com/serde-rs/serde/releases) - [Commits](serde-rs/serde@v1.0.123...v1.0.125) Signed-off-by: dependabot-preview[bot] <[email protected]>
…/serde-1.0.125 Bump serde from 1.0.123 to 1.0.125
|
As the latest update in vidify.org stated, I will no longer try to directly integrate Rust into Vidify. Rather, the audiosync extension will work just like the previous one did: it'll be implemented in a lower level language (Rust instead of C) and have a set of Python bindings so that it can be used as an extension. I will now try to refactor this PR and clean up what I've changed. Perhaps that'd be better off in a new PR. |
|
I can confirm I will be working on this in a new PR: #159 |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very WIP PR of the Rust integration mentioned in #107. Only the Vidify core is rewritten into Rust, leaving the GUI and similar elements in Python for now. Audiosync is also being re-implemented in Rust at https://github.com/vidify/audiosync-rs, in a separate crate so that it can be used by anyone outside of Vidify, too.
Tasks:
Integrate Dependabot, this should happen after the mergeProper error handling from Rust to Python, blocked by Add a proc macro for exceptions PyO3/pyo3#295 so maybe later on