Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor iOS project #211

Merged
merged 10 commits into from
Jan 15, 2018
Merged

Refactor iOS project #211

merged 10 commits into from
Jan 15, 2018

Conversation

hansemannn
Copy link
Collaborator

@hansemannn hansemannn commented Jan 15, 2018

Hey @viezel!

The community is still in love with this module, so I decided to do a quick update.
So This PR attempts to ...

  • Rebuild the module with latest 7.0.1. GA (not required but helpful)
  • Remove old meta-data (placeholder for license, changelog and old python scripts)
  • Add a LICENSE to the module root
  • Fix all static analyser warnings (unused properties, dead-assignments)
  • Move the project to ARC
  • Fix all memory leaks (some in the static analyser, some because of ARC)
  • Lint the iOS-source to match a more modern and unified code-style
  • Improve the compatibility with the iPhone X and future-devices (based on Update MMDrawerController.m mutualmobile/MMDrawerController#504)
  • Expose centerWindowDidFocus and centerWindowDidBlur event on the drawer
  • Bump the version to 2.0.0 to indicate the major changes

Likely to fix:

Binary: dk.napp.drawer-iphone-2.0.0.zip

@viezel viezel merged commit 21d31af into viezel:master Jan 15, 2018
@viezel
Copy link
Owner

viezel commented Jan 15, 2018

@hansemannn wonderful!!
I just added you as a contributor (as you are far more active than me in appc). Let me know if you want access to other repos :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants