-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Make robohive_env_suite an iterator #109
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
get_visuals() checks obs_keys instead visual_keys for depth logging.
- Wall clock and sim_time was being compared which sped up the initial few steps. - Default script to demo the robot was state. Reviving
* Allow examine_envs to load hard coded policies, E.g. python robohive/utils/examine_env.py -e FrankaReachRandom-v0 -p robohive.utils.examine_env.rand_policy * Remove unnecessary import * examine_env loading scripted polcies: update DESC in examine_env and add unit test Co-authored-by: Patrick Lancaster <[email protected]>
…e tolerance to the extero checks
…rward. Updating setup and docs
…nittests to catch the logger bugs. It will need a lot more tests to compherensively test the logger - logger format wasn't properly dlowing through introducing a few bugs along the way
… RANDOM_2D variants, as well as subgroups
…ary checks for mujoco_py compilation if its not in use
…egistered envs accross all suites. + Major rewamping the unit tests. Envs names are automatically fetched now. This helped catch a lot of new bugs that were getting ignored. All were minor fixes (missing camera, keys, etc)
…ite to skip sigmoid reprojection
… add randomization in the kitchen envs by making the franka_base reposition wrt to the kitchen at every reset. BUG: In our observations, ee_pos is present which provides global information about the grippers thereby also revealing the relative location between the kitchen and the robot. IMPLICATIONS: For state-based envs, this isn't as problematic. But for visual envs, this is quite problematic as the information that is required for visual generalization is being leaked by the ee_pose. FIX: The proposed fix is to update the ee_pose to provide values relative to the Franka robot's base, instead of the global ee_pose
- ee_pose_wrt_world is required for the obs. Without it the policy will be blind to the relative location of the kitchen - ee_pose_wrt_robot is required for proprioception. The visual inputs will provide the relative location of the kitchen in this case
…ding MyoLegs to mj236
…LITE can now disable checks on envs that require encoder downloads
…e with FIXED and RANDOM convensions. Removing the franka_kitchen_v1.py
* add rendering test * add ffmpeg
Should be against dev sorry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dev
branch (add test todev
branch #100)