-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V0.7.0: Gymnasium Upgrade. Multiple teleOP controllers. MuJoCo upgrade #135
Conversation
…venting full range of motion
…st unpickling. Better handling for future gym versions
… versions - adding an helper util to prioritize gymnasium import over gym - standardizing gym_registry_specs for robohive env registration - moving all self.np_random.randint to self.np_random.choice as its more standard across versions - bugfix in range specifications. high-low<0 for a few instances - Adding a buffer (*_) in step and forward to accommodate different number of entities returned - starting to use env.unwrapped instead of env.env..... - robustifying test_logger. It can effectively fish out the log names now
…rom randint to choice
…ience. Most env suite upgraded. Others are WIP and will come with next few commits
…back to the previous versions. This should be undone in the future when this feature is stable
…d. Others are WIP and will come with next few commits
- Updating to myochallenge'23 envs release
… Defaulting to free camera
… By default path_utils uses unwrapped envs now
…ting it back to the previous versions. This should be undone in the future when this feature is stable" This reverts commit ae51c9e.
…=0.13. Feel free to revert back to this when facing instability due to gym versions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally. All test cases passed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Summary
We made a rebase and merge and got into trouble.
We learned that rebase creates a new commit hash, independent of the commit history. This is coz the hash depends on the metadata which changes during rebase.
Lessons Learned
cc @Vittorio-Caggiano @vittorione94