Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V0.7.0: Gymnasium Upgrade. Multiple teleOP controllers. MuJoCo upgrade #135

Merged
merged 62 commits into from
Mar 26, 2024

Conversation

vikashplus
Copy link
Owner

@vikashplus vikashplus commented Mar 24, 2024

Summary

We made a rebase and merge and got into trouble.
We learned that rebase creates a new commit hash, independent of the commit history. This is coz the hash depends on the metadata which changes during rebase.

Lessons Learned

  • Rebase on local commits is okay
  • Rebase on remote commits is bad. It is better to do merge commits (it creates additional merge commits on top of the current history)

cc @Vittorio-Caggiano @vittorione94

Vittorio-Caggiano and others added 30 commits October 10, 2023 18:18
…st unpickling. Better handling for future gym versions
… versions

- adding an helper util to prioritize gymnasium import over gym
- standardizing gym_registry_specs for robohive env registration
- moving all self.np_random.randint to self.np_random.choice as its more standard across versions
- bugfix in range specifications. high-low<0 for a few instances
- Adding a buffer (*_) in step and forward to accommodate different number of entities returned
- starting to use env.unwrapped instead of env.env.....
- robustifying test_logger. It can effectively fish out the log names now
…ience. Most env suite upgraded. Others are WIP and will come with next few commits
…back to the previous versions. This should be undone in the future when this feature is stable
…d. Others are WIP and will come with next few commits
@vikashplus vikashplus changed the title V0.7.0 Release: Gymnasium V0.7.0: Gymnasium Upgrade. Multiple teleOP controllers. MuJoCo upgrade Mar 24, 2024
robohive/envs/env_base.py Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
robohive/__init__.py Outdated Show resolved Hide resolved
robohive/envs/arms/pick_place_v0.py Outdated Show resolved Hide resolved
robohive/envs/env_base.py Show resolved Hide resolved
robohive/envs/env_base.py Show resolved Hide resolved
…=0.13. Feel free to revert back to this when facing instability due to gym versions
Copy link
Collaborator

@Vittorio-Caggiano Vittorio-Caggiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

README.md Outdated Show resolved Hide resolved
robohive/utils/prompt_utils.py Show resolved Hide resolved
Copy link
Collaborator

@ShahRutav ShahRutav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally. All test cases passed.

Copy link
Contributor

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vikashplus vikashplus merged commit 12a5497 into main Mar 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants