Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Point cloud utility functions for mujoco [Draft] #85

Merged
merged 5 commits into from
Apr 18, 2024

Conversation

Wenxuan-Zhou
Copy link

Ongoing

@vikashplus vikashplus mentioned this pull request Nov 3, 2023
@vikashplus
Copy link
Owner

@Wenxuan-Zhou we received a request for point cloud support in RoboHive. It will be great to develop and get this feature integrated.
#116

@Wenxuan-Zhou
Copy link
Author

Will work on this as soon as possible!

@Wenxuan-Zhou
Copy link
Author

I have updated the code and provided an example in the colab.
I noticed that the depth image is upside-down compared to rgb. Is there any reason for that? @vikashplus

@vikashplus
Copy link
Owner

IIRC it was upside down in MuJoCo_py. So it might be a stale rationale that needs an update for new official wrappers. This is the line where it happens. Feel free to test and add the fix to your PR.

@Wenxuan-Zhou
Copy link
Author

I have commented out the line you mentioned and verified the output. It should be ready to merge!

@shivakanthsujit
Copy link

Hello,

I am using these files and they work out of the box with the current robohive version. Could this PR be merged into main?

@vikashplus vikashplus changed the base branch from main to dev April 18, 2024 16:58
@vikashplus vikashplus merged commit a43298c into vikashplus:dev Apr 18, 2024
1 check passed
@vikashplus
Copy link
Owner

@shivakanthsujit -- mered into dev. It will go out with the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants