Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝 Use Entrypoint style in example codes #13

Merged
merged 2 commits into from
May 14, 2024
Merged

Conversation

lambdalisue
Copy link
Member

@lambdalisue lambdalisue commented May 14, 2024

Summary by CodeRabbit

  • Documentation
    • Updated tutorials to reflect the latest versions of denops.vim (v6.1.0) and denops_std (v6.5.0).
    • Changed function declarations to use constant arrow functions for better readability and consistency.
    • Revised import statements to align with new dependency versions.

Copy link

coderabbitai bot commented May 14, 2024

Walkthrough

The updates involve upgrading the Denops plugin tutorial to use newer versions of dependencies, specifically moving from denops_std v6.0.0 to v6.5.0 and unknownutil from v3.14.1 to v3.18.1. Additionally, the main function declarations have been refactored to constant arrow functions of type Entrypoint. These changes ensure compatibility with the latest Denops standards and improve code clarity.

Changes

Files/Paths Change Summary
src/getting-started/README.md
src/getting-started/explanation.md
Updated imports and function signature to use Entrypoint from denops_std v6.5.0.
src/tutorial.md Updated Denops plugin tutorial versions to denops.vim v6.1.0 and denops_std v6.5.0.
src/tutorial/helloworld/adding-an-api.md
.../calling-vim-features.md
.../creating-a-minimal-denops-plugin.md
Updated imports and function signature in main.ts to use Entrypoint from denops_std v6.5.0.
src/tutorial/maze/adjusting-maze-size-to-fit-the-window.md
.../creating-applicative-plugin.md
.../outputting-content-to-buffer.md
.../properly-configured-the-buffer.md
.../properly-create-a-virtual-buffer.md
.../reduce-the-number-of-rpc-calls.md
.../utilizing-denops-std-library.md
.../utilizing-third-party-library.md
Updated imports and function signature in main.ts to use Entrypoint from denops_std v6.5.0 and other related updates.

In code's vast field, we hop and play,
Updating paths, come what may.
From Denops to Entrypoint, we steer,
With each new version, we persevere.
The plugins dance in harmony's tune,
As bunnies code beneath the moon.
🌙🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 5

Out of diff range and nitpick comments (1)
src/getting-started/explanation.md (1)

Line range hint 45-45: Specify the language for the fenced code block.

- ```
+ ```typescript
Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 6aeb2f2 and ed114f1.
Files selected for processing (14)
  • src/getting-started/README.md (1 hunks)
  • src/getting-started/explanation.md (3 hunks)
  • src/tutorial.md (1 hunks)
  • src/tutorial/helloworld/adding-an-api.md (1 hunks)
  • src/tutorial/helloworld/calling-vim-features.md (2 hunks)
  • src/tutorial/helloworld/creating-a-minimal-denops-plugin.md (1 hunks)
  • src/tutorial/maze/adjusting-maze-size-to-fit-the-window.md (2 hunks)
  • src/tutorial/maze/creating-applicative-plugin.md (1 hunks)
  • src/tutorial/maze/outputting-content-to-buffer.md (2 hunks)
  • src/tutorial/maze/properly-configured-the-buffer.md (2 hunks)
  • src/tutorial/maze/properly-create-a-virtual-buffer.md (2 hunks)
  • src/tutorial/maze/reduce-the-number-of-rpc-calls.md (2 hunks)
  • src/tutorial/maze/utilizing-denops-std-library.md (2 hunks)
  • src/tutorial/maze/utilizing-third-party-library.md (1 hunks)
Additional comments not posted (23)
src/tutorial/maze/outputting-content-to-buffer.md (2)

10-10: Import statement updated to use Entrypoint from [email protected].


Line range hint 13-22: Function declaration updated to use Entrypoint and the function body remains consistent with the tutorial's objective.

src/tutorial.md (1)

9-11: Version numbers updated to denops.vim v6.1.0 and denops_std v6.5.0.

src/tutorial/helloworld/adding-an-api.md (2)

10-11: Import statements updated to use Entrypoint from [email protected] and [email protected].


13-20: Function declaration updated to use Entrypoint and the function body remains consistent with the tutorial's objective.

src/getting-started/README.md (2)

25-25: Import statement updated to use Entrypoint from [email protected].


27-33: Function declaration updated to use Entrypoint and the function body remains consistent with the tutorial's objective.

src/tutorial/helloworld/creating-a-minimal-denops-plugin.md (2)

35-35: Import statement updated to use Entrypoint from [email protected].


37-39: Function declaration updated to use Entrypoint and the function body remains consistent with the tutorial's objective.

src/tutorial/helloworld/calling-vim-features.md (2)

8-9: Import statements updated to use Entrypoint from [email protected] and [email protected].


Line range hint 11-26: Function declaration updated to use Entrypoint and the function body remains consistent with the tutorial's objective.

src/tutorial/maze/properly-configured-the-buffer.md (2)

10-13: Import statements updated to use Entrypoint and other modules from [email protected].


Line range hint 16-36: Function declaration updated to use Entrypoint and the function body remains consistent with the tutorial's objective.

src/tutorial/maze/adjusting-maze-size-to-fit-the-window.md (2)

11-12: Import statements updated to use Entrypoint and other modules from [email protected].


Line range hint 15-31: Function declaration updated to use Entrypoint and the function body remains consistent with the tutorial's objective.

src/tutorial/maze/utilizing-third-party-library.md (1)

35-43: LGTM! The function declaration has been correctly updated to use Entrypoint.

src/tutorial/maze/creating-applicative-plugin.md (1)

Line range hint 43-57: LGTM! The function declaration has been correctly updated to use Entrypoint.

src/tutorial/maze/properly-create-a-virtual-buffer.md (1)

Line range hint 18-35: LGTM! The function declaration has been correctly updated to use Entrypoint.

src/tutorial/maze/utilizing-denops-std-library.md (1)

Line range hint 29-57: LGTM! The function declaration has been correctly updated to use Entrypoint.

src/tutorial/maze/reduce-the-number-of-rpc-calls.md (1)

Line range hint 16-39: LGTM! The function declaration has been correctly updated to use Entrypoint.

src/getting-started/explanation.md (3)

94-94: LGTM! The import statement has been correctly updated to use Entrypoint.


96-102: LGTM! The function declaration has been correctly updated to use Entrypoint.


Line range hint 110-154: LGTM! The explanation has been correctly updated to reflect the new Entrypoint type.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 6

Out of diff range and nitpick comments (2)
src/tutorial/helloworld/adding-an-api.md (2)

Line range hint 38-38: Specify the language for the fenced code block.

Specify the language for the fenced code block to improve syntax highlighting.

- ```
+ ```typescript

Line range hint 44-44: Add alternate text for the image.

Add alternate text for the image to improve accessibility.

- ![](./img/adding-an-api-01.png)
+ ![Adding an API](./img/adding-an-api-01.png)
Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between ed114f1 and e316b72.
Files selected for processing (16)
  • .github/workflows/mdbook.yml (1 hunks)
  • .github/workflows/test.yml (2 hunks)
  • src/getting-started/README.md (1 hunks)
  • src/getting-started/explanation.md (3 hunks)
  • src/tutorial.md (1 hunks)
  • src/tutorial/helloworld/adding-an-api.md (1 hunks)
  • src/tutorial/helloworld/calling-vim-features.md (2 hunks)
  • src/tutorial/helloworld/creating-a-minimal-denops-plugin.md (1 hunks)
  • src/tutorial/maze/adjusting-maze-size-to-fit-the-window.md (2 hunks)
  • src/tutorial/maze/creating-applicative-plugin.md (1 hunks)
  • src/tutorial/maze/outputting-content-to-buffer.md (2 hunks)
  • src/tutorial/maze/properly-configured-the-buffer.md (2 hunks)
  • src/tutorial/maze/properly-create-a-virtual-buffer.md (2 hunks)
  • src/tutorial/maze/reduce-the-number-of-rpc-calls.md (2 hunks)
  • src/tutorial/maze/utilizing-denops-std-library.md (2 hunks)
  • src/tutorial/maze/utilizing-third-party-library.md (1 hunks)
Files skipped from review as they are similar to previous changes (3)
  • src/tutorial/maze/outputting-content-to-buffer.md
  • src/tutorial/maze/properly-configured-the-buffer.md
  • src/tutorial/maze/reduce-the-number-of-rpc-calls.md
Additional comments not posted (23)
.github/workflows/test.yml (1)

9-10: Ensure that the branches specified for the push event are correct and intended.

Please confirm that the main branch is the only branch intended for this workflow.

src/tutorial.md (1)

9-12: Ensure the version updates are correct and the links are valid.

Please verify that the versions v6.0.7 for denops.vim and v6.5.0 for denops_std are correct and that the links point to the correct release pages.

src/tutorial/helloworld/adding-an-api.md (2)

10-11: Ensure the import statements are correct and the versions are updated.

Please verify that the import statements for Entrypoint and unknownutil are correct and that the versions v6.5.0 and v3.18.1 are accurate.


13-20: Ensure the function declaration is correct and follows the new Entrypoint style.

The function declaration has been correctly updated to use the Entrypoint style.

.github/workflows/mdbook.yml (1)

39-40: Ensure the installation commands are correct and necessary.

The installation commands for mdbook and mdbook-alerts are correct and necessary for the workflow.

src/getting-started/README.md (1)

25-33: The changes to use Entrypoint style are correct and consistent with the PR objectives.

src/tutorial/helloworld/creating-a-minimal-denops-plugin.md (1)

35-39: The changes to use Entrypoint style are correct and consistent with the PR objectives.

src/tutorial/helloworld/calling-vim-features.md (1)

Line range hint 8-26: The changes to use Entrypoint style are correct and consistent with the PR objectives.

src/tutorial/maze/adjusting-maze-size-to-fit-the-window.md (1)

Line range hint 11-31: The changes to use Entrypoint style are correct and consistent with the PR objectives.

src/tutorial/maze/utilizing-third-party-library.md (2)

32-33: Import statements updated correctly.


35-43: Function declaration updated correctly.

src/tutorial/maze/creating-applicative-plugin.md (2)

36-41: Import statements updated correctly.


Line range hint 43-57: Function declaration updated correctly.

src/tutorial/maze/properly-create-a-virtual-buffer.md (2)

13-15: Import statements updated correctly.


Line range hint 18-35: Function declaration updated correctly.

src/tutorial/maze/utilizing-denops-std-library.md (2)

23-26: Import statements updated correctly.


Line range hint 29-57: Function declaration updated correctly.

src/getting-started/explanation.md (6)

94-94: Correctly updated the import statement to use Entrypoint from the new version of denops_std.


96-102: Correctly updated the function declaration to use the Entrypoint type and an arrow function.


110-110: Correctly updated the explanation to reflect the new import statement.


113-122: Correctly updated the explanation to reflect the new import statement and provide additional details.


138-154: Correctly updated the note to reflect the new Entrypoint type and provide additional details.


158-160: Correctly updated the function declaration to use the Entrypoint type and an arrow function.

.github/workflows/test.yml Show resolved Hide resolved
src/tutorial.md Show resolved Hide resolved
src/getting-started/README.md Show resolved Hide resolved
@lambdalisue lambdalisue merged commit 4e10ba0 into main May 14, 2024
2 checks passed
@lambdalisue lambdalisue deleted the use-entrypoint branch May 14, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant