hashに応じてアーカイブページへ遷移する機能を実装 #1263
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staticWagomU
requested review from
kyoh86,
monaqa,
peacock0803sz,
ryoppippi and
thinca
as code owners
monaqa
reviewed
Nov 2, 2025
Contributor
monaqa
left a comment
monaqa
left a comment
There was a problem hiding this comment.
ありがとうございます。助かります。
この PR でなくてもよいのですが、アーカイブページに遷移したときに対応するエントリを一瞬だけ光らせることって簡単に可能だったりしますか？
大量に記事が並んでいるところにページが移るので、どのエントリかすぐ分かるようにしたほうがいいかなと。
Contributor
Author
|
レビューありがとうございます！ 光らせるのいいですね！！帰宅後になりますがやってみます！！ |
Contributor
Author
|
途中で作業止まってしまってるので、明日か明後日再開します |
monaqa
approved these changes
Nov 5, 2025
Contributor
monaqa
left a comment
monaqa
left a comment
There was a problem hiding this comment.
自分から言い出しておいてなんですが、私の指摘は補足的なもので必須ではないと思うので、この PR は一旦マージして別 PR で実施でもよい気がしました！
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1012 (comment)
こちらの対応です。
例:
https://vim-jp.org/ekiden/#article-2025-09-01 がTOPページ内にない場合、https://vim-jp.org/ekiden/archives/#article-2025-09-01 へ遷移
content.jsonに存在しない日付の場合は、遷移しないようにしています。