fix(analyzer): correct composite string handling, and improve string casting #11467
+283
−91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azjezz
force-pushed
the
better-string-handling
branch
2 times, most recently
from
dc17232 to
875e8ab
Compare
azjezz
commented
Jun 3, 2025
Comment on lines
+211
to
221
| 'resourceOrFalseToString' => [ | ||
| 'code' => '<?php | ||
| $a = fopen("php://memory", "r"); | ||
| if (rand(0, 1)) { | ||
| $a = []; | ||
| } | ||
|
|
||
| // b = "Array"|""|"Resource id #1" | ||
| $b = (string) $a;', | ||
| ], | ||
| ]; |
There was a problem hiding this comment.
previously considered failing due to the assumpton plsam made that [] can't be cast to string.
There was a problem hiding this comment.
@danog should we emit a warning of some sort when casting arrays to strings? it will always result in Array and casting whatever array to string is most likely a mistake.
…casting closes vimeo#11465 closes vimeo#11466 closes vimeo#11464 Signed-off-by: azjezz <[email protected]>
azjezz
force-pushed
the
better-string-handling
branch
from
875e8ab to
1fae6ec
Compare
|
Unrelated note, there seem to be too many classes to represent string currently, I think it would make sense to reduce all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #11465
closes #11466
closes #11464