Skip to content

Accept null upload_link #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Accept null upload_link #327

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
62e0e4e
Accept null upload_link
divparikh Dec 13, 2022
10a3ba0
Update annotation
divparikh Dec 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Vimeo/Upload/TusClient.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@ class TusClient extends \TusPhp\Tus\Client
{
/**
* Sets the url for retrieving the TUS upload.
* @param string $url
* @param string|null $url
* @return $this
*/
public function setUrl(string $url)
public function setUrl(?string $url)
{
$this->url = $url;
return $this;
Expand Down
4 changes: 2 additions & 2 deletions src/Vimeo/Upload/TusClientFactory.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@ class TusClientFactory
{
/**
* @param string $base_uri The fully qualified domain of the upload, ex: https://us-files.tus.vimeo.com
* @param string $url The fully qualified url of the upload, ex: https://us-files.tus.vimeo.com/files/vimeo-a1b2c3d4
* @param string|null $url The fully qualified url of the upload, ex: https://us-files.tus.vimeo.com/files/vimeo-a1b2c3d4
* @return Client
*/
public function getTusClient(string $base_uri, string $url) : Client
public function getTusClient(string $base_uri, ?string $url) : Client
{
$client = new TusClient($base_uri);
$client->setUrl($url);
Expand Down