-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix block bitmap area calculation #638
base: trunk
Are you sure you want to change the base?
Conversation
This PR also fixes out of space errors when we used the whole disk. |
And now when we are out of disk we get the correct numbers:
The system doesn't crash, there's just no writes to disk possible. |
To test the disk I generated a number of files with precise sizes on the host like this 100 KB file:
Then I launched a HTTP server in the dir on the host:
And I downloaded the file from MOROS:
|
This is a breaking change that is very close to the summer solstice release date of MOROS so we'll merge it after the release to have 3 months to test it before the next. |
The formula used to calculate the size of the block bitmap area was not correct, resulting in blocks that cannot be allocated. This issue surfaced after #637 when using about half of the disk.
One thing to note is that this PR will likely extend the size of the block bitmap area by one or more blocks so we must increase the version number of MFS to use the old formula on existing disks.