Skip to content

Commit

Permalink
feat(secrets): use github secrets instead of gcp secrets
Browse files Browse the repository at this point in the history
  • Loading branch information
@vincejv
vincejv committed Aug 25, 2023
1 parent fb4d246 commit 2628356
Show file tree
Hide file tree
Showing 2 changed files with 57 additions and 54 deletions.
56 changes: 29 additions & 27 deletions .github/workflows/release-dev.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -154,33 +154,35 @@ jobs:
region: ${{ env.REGION }}
image: ${{ steps.image_version.outputs.service_image_path }}
project_id: ${{ env.PROJECT_ID }}
flags: --cpu ${{ env.SERVICE_CPU }} --memory ${{ env.SERVICE_MEMORY }} --timeout 900 --no-cpu-throttling
env_vars: |
DB_NAME=load-api-dev
OIDC_CLIENT_ID=${{ secrets.OIDC_CLIENT_ID }}
OIDC_AUTH_URL=${{ secrets.OIDC_AUTH_URL }}
GL_REWARDS_API=${{ secrets.GL_REWARDS_API }}
GL_APP_ID=${{ secrets.GL_APP_ID }}
DTONE_BASEURL=${{ secrets.DTONE_BASEURL }}
DTONE_APIKEY=${{ secrets.DTONE_APIKEY }}
DTONE_CALLBACK_URL=${{ secrets.DTONE_CALLBACK_URL }}
LOGIN_BASE_URI=${{ secrets.LOGIN_BASE_URI }}
SMS_BASE_URI=${{ secrets.SMS_BASE_URI }}
FPI_APP_TO_APP_USERN=${{ secrets.FPI_APP_TO_APP_USERN }}
USER_BASE_URI=${{ secrets.USER_BASE_URI }}
MSGR_API_BASE_URI=${{ secrets.MSGR_API_BASE_URI }}
TG_API_BASE_URI=${{ secrets.TG_API_BASE_URI }}
VIBER_API_BASE_URI=${{ secrets.VIBER_API_BASE_URI }}
secrets: |
MONGO_CONN_STRING=vbl_mongo_connection_string:latest
OIDC_SECRET=oidc_secret_keycloak:latest
GL_APP_SEC=gl_app_secret:latest
FPI_MO_WEBHOOK_KEY=fpi_mo_incoming_webook_key:latest
FPI_DLR_WEBHOOK_KEY=fpi_dlr_incoming_webhook_key:latest
FPI_GEN_WEBHOOK_KEY=fpi_gen_incoming_webhook_key:latest
DTONE_APISECRET=dtone_api_secret:latest
GL_APP_AMAX_TOKEN=gl_app_amax_token:latest
FPI_APP_TO_APP_PASSW=fpi_load_api_creds_secret_key:latest
flags: |
--set-env-vars ^##^MONGO_CONN_STRING=${{ secrets.MONGO_CONN_STRING }}
--set-env-vars OIDC_CLIENT_ID=${{ secrets.OIDC_CLIENT_ID }}
--set-env-vars OIDC_AUTH_URL=${{ secrets.OIDC_AUTH_URL }}
--set-env-vars OIDC_SECRET=${{ secrets.OIDC_SECRET }}
--set-env-vars FPI_APP_TO_APP_USERN=${{ secrets.FPI_APP_TO_APP_USERN }}
--set-env-vars FPI_MO_WEBHOOK_KEY=${{ secrets.FPI_MO_WEBHOOK_KEY }}
--set-env-vars FPI_DLR_WEBHOOK_KEY=${{ secrets.FPI_DLR_WEBHOOK_KEY }}
--set-env-vars FPI_GEN_WEBHOOK_KEY=${{ secrets.FPI_GEN_WEBHOOK_KEY }}
--set-env-vars FPI_APP_TO_APP_PASSW=${{ secrets.FPI_APP_TO_APP_PASSW }}
--set-env-vars USER_BASE_URI=${{ secrets.USER_BASE_URI }}
--set-env-vars LOGIN_BASE_URI=${{ secrets.LOGIN_BASE_URI }}
--set-env-vars GL_REWARDS_API=${{ secrets.GL_REWARDS_API }}
--set-env-vars GL_APP_ID=${{ secrets.GL_APP_ID }}
--set-env-vars DTONE_BASEURL=${{ secrets.DTONE_BASEURL }}
--set-env-vars DTONE_APIKEY=${{ secrets.DTONE_APIKEY }}
--set-env-vars DTONE_CALLBACK_URL=${{ secrets.DTONE_CALLBACK_URL }}
--set-env-vars SMS_BASE_URI=${{ secrets.SMS_BASE_URI }}
--set-env-vars MSGR_API_BASE_URI=${{ secrets.MSGR_API_BASE_URI }}
--set-env-vars TG_API_BASE_URI=${{ secrets.TG_API_BASE_URI }}
--set-env-vars VIBER_API_BASE_URI=${{ secrets.VIBER_API_BASE_URI }}
--set-env-vars GL_APP_SEC=${{ secrets.GL_APP_SEC }}
--set-env-vars DTONE_APISECRET=${{ secrets.DTONE_APISECRET }}
--set-env-vars GL_APP_AMAX_TOKEN=${{ secrets.GL_APP_AMAX_TOKEN }}
--set-env-vars DB_NAME=load-api-dev
--cpu ${{ env.SERVICE_CPU }}
--memory ${{ env.SERVICE_MEMORY }}
--timeout 900
--no-cpu-throttling
labels: |
env=${{ env.SERVICE_ENV }}
Expand Down
55 changes: 28 additions & 27 deletions .github/workflows/release-main.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -196,33 +196,34 @@ jobs:
region: ${{ env.REGION }}
image: ${{ needs.versioning.outputs.service_image_path }}
project_id: ${{ env.PROJECT_ID }}
flags: --cpu ${{ env.SERVICE_CPU }} --memory ${{ env.SERVICE_MEMORY }} --no-cpu-throttling
env_vars: |
DB_NAME=load-api-prod
OIDC_CLIENT_ID=${{ secrets.OIDC_CLIENT_ID }}
OIDC_AUTH_URL=${{ secrets.OIDC_AUTH_URL }}
GL_REWARDS_API=${{ secrets.GL_REWARDS_API }}
GL_APP_ID=${{ secrets.GL_APP_ID }}
DTONE_BASEURL=${{ secrets.DTONE_BASEURL }}
DTONE_APIKEY=${{ secrets.DTONE_APIKEY }}
DTONE_CALLBACK_URL=${{ secrets.DTONE_CALLBACK_URL }}
LOGIN_BASE_URI=${{ secrets.LOGIN_BASE_URI }}
SMS_BASE_URI=${{ secrets.SMS_BASE_URI }}
FPI_APP_TO_APP_USERN=${{ secrets.FPI_APP_TO_APP_USERN }}
USER_BASE_URI=${{ secrets.USER_BASE_URI }}
MSGR_API_BASE_URI=${{ secrets.MSGR_API_BASE_URI }}
TG_API_BASE_URI=${{ secrets.TG_API_BASE_URI }}
VIBER_API_BASE_URI=${{ secrets.VIBER_API_BASE_URI }}
secrets: |
MONGO_CONN_STRING=vbl_mongo_connection_string:latest
OIDC_SECRET=oidc_secret_keycloak:latest
GL_APP_SEC=gl_app_secret:latest
FPI_MO_WEBHOOK_KEY=fpi_mo_incoming_webook_key:latest
FPI_DLR_WEBHOOK_KEY=fpi_dlr_incoming_webhook_key:latest
FPI_GEN_WEBHOOK_KEY=fpi_gen_incoming_webhook_key:latest
DTONE_APISECRET=dtone_api_secret:latest
GL_APP_AMAX_TOKEN=gl_app_amax_token:latest
FPI_APP_TO_APP_PASSW=fpi_load_api_creds_secret_key:latest
flags: |
--set-env-vars ^##^MONGO_CONN_STRING=${{ secrets.MONGO_CONN_STRING }}
--set-env-vars OIDC_CLIENT_ID=${{ secrets.OIDC_CLIENT_ID }}
--set-env-vars OIDC_AUTH_URL=${{ secrets.OIDC_AUTH_URL }}
--set-env-vars OIDC_SECRET=${{ secrets.OIDC_SECRET }}
--set-env-vars FPI_APP_TO_APP_USERN=${{ secrets.FPI_APP_TO_APP_USERN }}
--set-env-vars FPI_MO_WEBHOOK_KEY=${{ secrets.FPI_MO_WEBHOOK_KEY }}
--set-env-vars FPI_DLR_WEBHOOK_KEY=${{ secrets.FPI_DLR_WEBHOOK_KEY }}
--set-env-vars FPI_GEN_WEBHOOK_KEY=${{ secrets.FPI_GEN_WEBHOOK_KEY }}
--set-env-vars FPI_APP_TO_APP_PASSW=${{ secrets.FPI_APP_TO_APP_PASSW }}
--set-env-vars USER_BASE_URI=${{ secrets.USER_BASE_URI }}
--set-env-vars LOGIN_BASE_URI=${{ secrets.LOGIN_BASE_URI }}
--set-env-vars GL_REWARDS_API=${{ secrets.GL_REWARDS_API }}
--set-env-vars GL_APP_ID=${{ secrets.GL_APP_ID }}
--set-env-vars DTONE_BASEURL=${{ secrets.DTONE_BASEURL }}
--set-env-vars DTONE_APIKEY=${{ secrets.DTONE_APIKEY }}
--set-env-vars DTONE_CALLBACK_URL=${{ secrets.DTONE_CALLBACK_URL }}
--set-env-vars SMS_BASE_URI=${{ secrets.SMS_BASE_URI }}
--set-env-vars MSGR_API_BASE_URI=${{ secrets.MSGR_API_BASE_URI }}
--set-env-vars TG_API_BASE_URI=${{ secrets.TG_API_BASE_URI }}
--set-env-vars VIBER_API_BASE_URI=${{ secrets.VIBER_API_BASE_URI }}
--set-env-vars GL_APP_SEC=${{ secrets.GL_APP_SEC }}
--set-env-vars DTONE_APISECRET=${{ secrets.DTONE_APISECRET }}
--set-env-vars GL_APP_AMAX_TOKEN=${{ secrets.GL_APP_AMAX_TOKEN }}
--set-env-vars DB_NAME=load-api-prod
--cpu ${{ env.SERVICE_CPU }}
--memory ${{ env.SERVICE_MEMORY }}
--no-cpu-throttling
labels: |
env=${{ env.SERVICE_ENV }}
Expand Down

0 comments on commit 2628356

Please sign in to comment.