This repository has been archived by the owner on Dec 5, 2022. It is now read-only.
Image Minification and WebP Version #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 3, 2019 14:40
From 770 kb to 219 kb without losing quality
viniciuskneves
suggested changes
Oct 4, 2019
There was a problem hiding this comment.
Hey @dougfabris thanks for you PR.
I've added a small request and also would kindly ask you to follow Gitmoji (https://github.com/viniciuskneves/ichbineinekartoffel.de#contribution-guidelines) on your commits.
index.html
Outdated
| <picture> | ||
| <source type="image/webp" srcset="./ichbineinekartoffel.webp" /> | ||
| <source srcset="./ichbineinekartoffel.png" /> | ||
| <img src="./ichbineinekartoffel.png" loading="lazy" alt="Ich bin eine kartoffel : I am a potato" /> |
There was a problem hiding this comment.
I don't think lazy is necessary here as it is the main content from this webpage and should be loaded as soon as possible.
There was a problem hiding this comment.
I agree with you. Sorry for not respect contribute guideline. I used it in the commit below.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue reference: #3