complete specs for stock movement model #137

sawangupta92 · 2016-02-29T06:27:52Z

Use constant QUANTITY_LIMITS for maximum and minimum quantity.
Use persisted? instead of !new_record? in #readonly?.
Write rspecs for Constants, Associations, Validations, Callbacks, Ransackable attributes, Scope, #readonly?
Move #update_stock_item_quantity to describe block of Instance Methods

1) use is_expected syntax for should a matcher 2) change quantity contstants to a single hash

jitendra · 2016-03-03T07:31:15Z

core/app/models/spree/stock_movement.rb

+    QUANTITY = {
+      max: 2147483647,
+      min: -2147483648
+    }


Please use 2*31 instead of exact number. Rename it to QUANTITY_LIMITS

…t value

jitendra · 2016-03-09T05:22:51Z

@sawangupta92 please add proper description to this PR.

jitendra · 2016-03-17T05:22:32Z

@sawangupta92 It looks good to me. Please raise on Spree with same description in PR

sawangupta92 added 2 commits February 28, 2016 01:43

complete specs for stock movement model

04248e7

update sytax

4bde471

1) use is_expected syntax for should a matcher 2) change quantity contstants to a single hash

tanmay3011 assigned jitendra Feb 29, 2016

jitendra reviewed Mar 3, 2016
View reviewed changes

jitendra assigned sawangupta92 and unassigned jitendra Mar 3, 2016

rename QUANTITY to QUANTITY_LIMITS and use 2**31 notation for constan…

86a2a0f

…t value

sawangupta92 assigned jitendra and unassigned sawangupta92 Mar 3, 2016

jitendra assigned sawangupta92 and unassigned jitendra Mar 9, 2016

sawangupta92 assigned jitendra and unassigned sawangupta92 Mar 10, 2016

jitendra assigned sawangupta92 and unassigned jitendra Mar 17, 2016

fix hound ci issues

45652ba

sawangupta92 force-pushed the spec-for-stock-movement branch from b0f7b9d to 45652ba Compare March 21, 2016 07:07

Provide feedback