Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: separating dependencies #105

Merged
merged 3 commits into from
Aug 4, 2024
Merged

feat: separating dependencies #105

merged 3 commits into from
Aug 4, 2024

Conversation

immois
Copy link
Member

@immois immois commented Aug 2, 2024

πŸ“ Description:

Remove dependencies on useWindowSize, useScrollPosition, and useClipboard.

βœ… Pull Request Checklist:

  • Add/Update feature.
  • Add/Update test.
  • Add/Update documentation.
  • Add/Update stories in storybook.
  • Bug fix.
  • Is this a breaking change

Copy link

changeset-bot bot commented Aug 2, 2024

πŸ¦‹ Changeset detected

Latest commit: 96c17f8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@raddix/use-clipboard Minor
@raddix/use-scroll-position Minor
@raddix/use-window-size Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Aug 2, 2024

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 95.30%. Comparing base (f909d57) to head (96c17f8).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #105   +/-   ##
=======================================
  Coverage   95.30%   95.30%           
=======================================
  Files          26       26           
  Lines         383      383           
  Branches       86       85    -1     
=======================================
  Hits          365      365           
  Misses         16       16           
  Partials        2        2           

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@immois immois marked this pull request as ready for review August 2, 2024 23:25
@immois immois changed the title feat: remove dependencies feat: separating dependencies Aug 4, 2024
@immois immois merged commit 0aee7d1 into main Aug 4, 2024
6 checks passed
@immois immois deleted the feat/hooks-dependencies branch August 4, 2024 01:57
immois added a commit that referenced this pull request Aug 4, 2024
Remove dependencies on useWindowSize, useScrollPosition, and useClipboard.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant