-
Notifications
You must be signed in to change notification settings - Fork 0
1.1.0 release #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.1.0 release #10
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideRelease prep for version 1.1.0: updates the project and demo package versions and documents new features in the changelog for directory-based SHC validation and revocation identifier support. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes and they look great!
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `CHANGELOG.md:12` </location>
<code_context>
+
+### Added
+
+- **Directories support**: `SHC` validation using `SHCReader` now supports the usage of directories for public key resolution and for revocation status check
+- **Revocation identifier support**: `SHCIssuer` can now issue `SHC` with a `rid` (revocation identifier) value, which can be used to determine if that Smart Health Card has been revoked
+
</code_context>
<issue_to_address>
**suggestion (typo):** Consider adjusting the ending phrase to a more natural grammatical form.
The phrase "for revocation status check" is a bit awkward. Consider "for revocation status checks" or "for checking revocation status" instead.
```suggestion
- **Directories support**: `SHC` validation using `SHCReader` now supports the usage of directories for public key resolution and for checking revocation status
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Coverage Report
File CoverageNo changed files found. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Summary by Sourcery
Release version 1.1.0 with updated changelog and package versions.
New Features:
Build: