Skip to content

Conversation

@rvlb
Copy link
Contributor

@rvlb rvlb commented Dec 17, 2025

Summary by Sourcery

Release version 1.1.0 with updated changelog and package versions.

New Features:

  • Add directory-based support in SHCReader for public key resolution and revocation status checks.
  • Allow SHCIssuer to issue SMART Health Cards with a revocation identifier (rid) used to determine revocation status.

Build:

  • Bump library and demo package versions from 1.0.2 to 1.1.0.

@rvlb rvlb requested a review from fjsj December 17, 2025 20:38
@sourcery-ai
Copy link

sourcery-ai bot commented Dec 17, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Release prep for version 1.1.0: updates the project and demo package versions and documents new features in the changelog for directory-based SHC validation and revocation identifier support.

File-Level Changes

Change Details Files
Document new 1.1.0 features in the changelog.
  • Add 1.1.0 section with an Added subsection
  • Describe new directory-based public key and revocation status resolution for SHCReader validation
  • Describe new revocation identifier (rid) support when issuing SHCs with SHCIssuer
CHANGELOG.md
Bump package versions from 1.0.2 to 1.1.0 for the main project and demos.
  • Update root package.json version to 1.1.0
  • Update demo SHL package.json version to 1.1.0
  • Update demo SHC package.json version to 1.1.0
  • Update medplum SHL demo package.json version to 1.1.0
package.json
demo/shl/package.json
demo/shc/package.json
demo/medplum-shl/package.json

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!

Prompt for AI Agents
Please address the comments from this code review:

## Individual Comments

### Comment 1
<location> `CHANGELOG.md:12` </location>
<code_context>
+
+### Added
+
+- **Directories support**: `SHC` validation using `SHCReader` now supports the usage of directories for public key resolution and for revocation status check
+- **Revocation identifier support**: `SHCIssuer` can now issue `SHC` with a `rid` (revocation identifier) value, which can be used to determine if that Smart Health Card has been revoked
+
</code_context>

<issue_to_address>
**suggestion (typo):** Consider adjusting the ending phrase to a more natural grammatical form.

The phrase "for revocation status check" is a bit awkward. Consider "for revocation status checks" or "for checking revocation status" instead.

```suggestion
- **Directories support**: `SHC` validation using `SHCReader` now supports the usage of directories for public key resolution and for checking revocation status
```
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@github-actions
Copy link

github-actions bot commented Dec 17, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 96.04% 2065 / 2150
🔵 Statements 96.04% 2065 / 2150
🔵 Functions 98.57% 138 / 140
🔵 Branches 90.01% 649 / 721
File CoverageNo changed files found.
Generated in workflow #120 for commit 3c83f9c by the Vitest Coverage Report Action

@vercel
Copy link

vercel bot commented Dec 17, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
medplum-shl Ready Ready Preview, Comment Dec 18, 2025 0:08am

@fjsj fjsj merged commit ce40ce5 into main Dec 18, 2025
6 checks passed
@fjsj fjsj deleted the v1.1.0-release branch December 18, 2025 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants