asserting in
#455
Draft
asserting in
#455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nfig # Conflicts: # src/main/scala/viper/carbon/verifier/BoogieInterface.scala
alexanderjsummers
requested changes
Mar 15, 2023
There was a problem hiding this comment.
I'm not sure how pull requests work across submodules; could this be a separate pull request for silver?
There was a problem hiding this comment.
In any case, github doesn't seem to understand how to present the diffs for these files.
There was a problem hiding this comment.
I did make two pull requests: see viperproject/silver#660, this pull request references the silver commit in the silver pull request
| case sil.Unfolding(_, exp) => | ||
| translateExp(exp) | ||
| case sil.Applying(_, exp) => translateExp(exp) | ||
| case h: sil.HintExp => translateExp(h.body) |
There was a problem hiding this comment.
This is nice to have. Is HintExp a sealed trait?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires viperproject/silver#660
This is my attempt at adding supporting the
asserting infeature in Carbon.The "tests/all/asserting-in/wand.vpr" test from silver fails. Although, when I was initially working on this, this was also an issue when encoding
asserting inusing function preconditions, now the error seems specific toasserting in, so it may be worth looking into.