Update numpy version to >=1.26.0 #474
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes issue virattt#416 by updating the numpy version constraint from "^1.24.0" to ">=1.26.0". The previous constraint (^1.24.0) locked numpy to 1.26.4 in poetry.lock, which doesn't have pre-built wheels for Windows ARM CPUs, causing installation failures. By allowing numpy >=1.26.0, Poetry can now select newer ARM-compatible versions (like 1.26.4+ or 2.x) that have proper ARM support. Fixes virattt#416
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes issue #416 by updating the numpy version constraint from "^1.24.0" to ">=1.26.0".
The previous constraint (^1.24.0) locked numpy to 1.26.4 in poetry.lock, which doesn't have pre-built wheels for Windows ARM CPUs, causing installation failures.
By allowing numpy >=1.26.0, Poetry can now select newer ARM-compatible versions (like 1.26.4+ or 2.x) that have proper ARM support.
Fixes #416