Fix Windows run.bat command parsing #478
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The script was not parsing command-line arguments because execution flowed directly into the :show_help function before reaching :parse_args. Changes: - Add goto :main_start after variable initialization to skip function definitions - Add :main_start label before :parse_args - Remove unreachable call :parse_args at end of file
nathanblart296-commits
approved these changes
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #411 - Windows run.bat script displays help instead of executing commands.
Root cause: Script execution flowed directly into
:show_helpfunction before reaching:parse_argsbecause:call :parse_args %*at end of file was unreachable (afterexit /b 0)Changes:
goto :main_startafter variable initialization to skip function definitions:main_startlabel before:parse_argscall :parse_args %*at end of fileTest plan
run.bat build- should execute build command instead of showing helprun.bat --ticker AAPL main- should run main with ticker argument