-
Notifications
You must be signed in to change notification settings - Fork 33
feat: support SEV-SNP Report Version 5 (temporary GitHub dependency) #114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
+16
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR integrates support for the new Entity relationship diagram for KeyArgs and DerivedKey with launch_mit_vectorerDiagram
KEYARGS {
Option u64 tcbv
Option u64 lmv
}
DERIVEDKEY {
root_key_select
GuestFieldSelect
vmpl
gsvn
tcbv
lmv
}
KEYARGS ||--o{ DERIVEDKEY : provides
Class diagram for updated KeyArgs struct and get_derived_key functionclassDiagram
class KeyArgs {
+Option<u64> tcbv
+Option<u64> lmv
}
class DerivedKey {
+new(root_key_select, GuestFieldSelect, vmpl, gsvn, tcbv, lmv)
}
class Firmware {
+open()
+get_derived_key(option, request)
}
KeyArgs --> DerivedKey : used in new()
DerivedKey --> Firmware : passed to get_derived_key()
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
fccd1d1 to
eeafc2c
Compare
- Use sev crate from GitHub (main branch) to support Report Version 5 - Update Cargo.toml with git dependency and required features - Modify code to handle new fields (e.g., launch_mit_vector) - Add description of --launch_mit_vector option in README.md Signed-off-by: Takuma IMAMURA <[email protected]>
eeafc2c to
6da72b5
Compare
Contributor
Author
|
This PR is replaced by #115 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for SEV-SNP Report Version 5 by updating the code and bumping the
sevcrate.Fixes #113
What's changed
sevcrate to the latest versionlaunch_mit_vector)README.mdto reflect these changesThis PR (draft) is a temporary workaround using an unreleased version of
sev. Once an official release of thesevcrate with Report V5 support becomes available, I will:Cargo.tomlto a versioned release.Cargo.lockaccordingly.Summary by Sourcery
Add support for SEV-SNP Report Version 5 by updating the sev dependency, handling the new launch_mit_vector field in key derivation, and updating documentation.
New Features:
Build:
Documentation: