Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(agents): live session turn counter alongside runtime timer #446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Uh oh!
There was an error while loading. Please reload this page.
feat(agents): live session turn counter alongside runtime timer #446
Changes from all commits
be976229349d64ca0936df884800c54a43afb659a942c8856File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fetchRunHistorypolls/api/agent-runsand/api/agent-runs/:idevery 5s and stores results inrunHistory/runDetail, but those state values are not used anywhere in this file. This adds recurring API load with no user-visible effect; either render the run history/detail UI or stop polling until it’s needed (e.g., fetch on-demand when opening a Runs tab).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test feeds
recordEvent()objects shaped like already-normalized session messages ({type, content, timestamp, meta}), butSessionTracker.recordEventonly treats events as “direct messages” when they includerole; otherwise they go through#normalizeEvent, which ignorescontent/meta/timestampfortool_calland always assignstimestamptonew Date(). As a result,toolCallsand especiallydurationMs: 4000will not match deterministically. Either adjust the test to use the supported input shapes (e.g., includeroleor use the SDK event fieldsname/arguments), or extendrecordEvent/#normalizeEventto accept and preserve normalized message objects withtype/content/timestamp/meta.Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.