[CI-NO-BUILD] [viostor] Programmatically determine max_segments #1298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Waiting on PR #1297 to merge before rebasing and review. |
This was referenced Feb 17, 2025
benyamin-codez
changed the title
Refactors VirtIoFindAdapter() to:
1. Enable Registry lookup for max_segments in value "MaxPhysicalSegments"
2. Refactor existing options into proposed vioscsi scaffold
3. Calc sectors from geometry and segments from sectors
4. Choose from among best candidates and check within limits
5. Enforce legacy StorPort NOPB off-by-one behaviour and provide explanation
6. Improves relevant instrumentation
Note: This commit enables the use of max_segments greater than
info.seg_max (max = 254) up to MAX_PHYS_SEGMENTS (presently 512).
This commit also fixes a NOPB off-by-one regression.
Signed-off-by: benyamin-codez <[email protected]>
benyamin-codez
force-pushed
the
viostor-max-segments
branch
from
d3f4b3c to
0552bdd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors
VirtIoFindAdapter()to:max_segmentsin value "MaxPhysicalSegments"vioscsiscaffoldNote: This commit enables the use of max_segments greater than
info.seg_max(max = 254) up toMAX_PHYS_SEGMENTS(presently 512).This commit also fixes a NOPB off-by-one regression.