[CI-NO-BUILD] [vioscsi] Align memory allocations #1313
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactors VioScsiFindAdapter() to: 1. Pad the uncached extension to ensure it is page-aligned 2. Update memory layout art 3. Improve relevant instrumentation 4. Adds VIRTIO_SCSI_MSI_CONTROL_Q_OFFSET and updates the QUEUE_TO_MESSAGE(QueueId) and MESSAGE_TO_QUEUE(MessageId) macros to use it (vioscsi.h) Signed-off-by: benyamin-codez <[email protected]>
|
Shares some definitions with PR #1306. Waiting for that to merge before rebasing. PR 1313 : I pray the devil isn't in the detail.... 8^O |
This was referenced Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors
VioScsiFindAdapter()to:VIRTIO_SCSI_MSI_CONTROL_Q_OFFSETand updates theQUEUE_TO_MESSAGE(QueueId)andMESSAGE_TO_QUEUE(MessageId)macros to use it (vioscsi.h)