Field Data Endpoint Implementation #1406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
jcschaff
force-pushed
the
field-data-bug-fix
branch
from
b6cf464 to
2be8592
Compare
AvocadoMoon
force-pushed
the
field-data-bug-fix
branch
from
4c9d81a to
a853019
Compare
Have the DB operation of retrieving all field data IDs of a user, and the shape information of a field data entry be done through the REST endpoints.
Before it would return a single object which had a list of other objects. Now it just returns a list of one object type, making what the API sends and receives a lot simpler.
The autogenerated spec for the REST API.
Put all of the example scripts so far created into their own respective package instead of the top level directory.
Some of the dependencies wouldn't work with PyCharms debugging capabilities, in addition some where missing for the Auth and Jupyter notebooks.
Ran the automated client generation script again to ensure nothing of importance has changed.
Reset the spacing while still keeping the changes I've made.
AvocadoMoon
force-pushed
the
field-data-bug-fix
branch
from
a853019 to
e9fd222
Compare
Imports when rebasing off of master got mis-mangled.
By specifying that the field data references is plural, it helps clarify as to what would be returned from the API.
AvocadoMoon
force-pushed
the
field-data-bug-fix
branch
from
deba142 to
6c440d9
Compare
Added the apiclient as a dependency to the client module so that it can execute during runtime when dependency injection is done with Guice.
jcschaff
approved these changes
Jan 13, 2025
There was a problem hiding this comment.
interactive reviews with @AvocadoMoon are complete, approved! Follow-on work is needed to clean up some maven module dependencies which are not ideal (outside the scope of this PR).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Within this PR request the following changes will be implemented:
The following field data endpoints
Introduce file system control within the REST module using the data set controller.
Method to interact with both antiquated and modern API for the DB and file system interactions
Revisions of the field data java client code, improving clarity, reordering code to the server side which was once client, and all while also reducing vectors for bugs by nature of simplicity.
Client libraries for Python, Java, and JavaScript regarding the new field data endpoints implemented