multi-architecture support #229
Conversation
build vsys against many javas
There was a problem hiding this comment.
#167 we need seriously check and package updates. We can not directly cite some 3rd party dependency directly since everyone can upload their complied package to mvn-repo. I already noticed many related packages listed. But for some security problems, we still keep the original dependency first, since this support is not necessary for all devices.
And you should also need to test this update work or not. Build the jar package and run the node on an Android phone or Raspberry Pi.
|
I think that I've chosen this package from a well-audited source, but if you have thoughts on another, please let me know. Does travis provide build artifacts? This builds now, because we have closed #226 what does the -all in a scala package refer to? Is it the instruction set architecture, or something else? compiling on raspberry pi, if that works I'll put it on my PinePhone |
Codecov Report
@@ Coverage Diff @@
## master #229 +/- ##
==========================================
- Coverage 63.70% 63.68% -0.02%
==========================================
Files 199 199
Lines 5744 5744
Branches 297 297
==========================================
- Hits 3659 3658 -1
- Misses 2085 2086 +1
Continue to review full report at Codecov.
|
|
@faddat you should also check that package based on this new dependency can be well start in the aarch64 device. |
|
So, seems I made it explode. Maybe library compatibility, I'll fiddle with it and see what I can do. do you have a link to a good document that explains scala compilation? I'd like to refactor our build system to use mill, but that did not go so great for me so far. |
ARM support confirmed. Imported module is well tested.
|
|
|
It even compiles on raspberry pie and pine phone, but there is the problem
with the old node preventing easy sync.
…On Wed, Sep 9, 2020, 12:04 PM ncying ***@***.***> wrote:
@faddat <https://github.com/faddat> you should also check that package
based on this new dependency can be will start in the aarch64 device.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#229 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABWPVCM4VZXZJARFW4P5XXDSE4EHVANCNFSM4RAQ47QA>
.
|
|
So I have reviewed this to the best of my knowledge. I do not think that it introduces any kind of security risk. If we merge it, we gain hardware build targets for VSYS software. |
Bring Current
Codecov Report
@@ Coverage Diff @@
## master #229 +/- ##
==========================================
- Coverage 66.42% 66.36% -0.07%
==========================================
Files 199 199
Lines 5770 5770
Branches 277 277
==========================================
- Hits 3833 3829 -4
- Misses 1937 1941 +4
Continue to review full report at Codecov.
|
PR Details
Enables aarch64 support
#167
Description
Related Issue
Motivation and Context
Phones and Pi's now support vsys
How Has This Been Tested
rpi 4 and pinephone
Types of changes
Checklist