Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No arm #257

Closed
wants to merge 32 commits into from
Closed

No arm #257

wants to merge 32 commits into from

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Jan 9, 2021

PR Details

  • Automatic docker image builds for amd64
  • Enhancement to setup process
  • Removal of ARM support found at https://github.com/faddat/v-systems
  • Sonarcloud ( needs small update to badge)

Related Issue

#194

Motivation and Context

Sonarcloud will improve code quality over time. docker containers are less reliant on their environment than bare JARR files and can be easier to administer.

How Has This Been Tested

On numerous cloud and physical devices.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added github actions to cover my changes.
  • All new and existing tests passed.

@faddat faddat requested a review from sunnyking January 9, 2021 19:12
@codecov-io
Copy link

Codecov Report

Merging #257 (a5647a4) into master (ad9c72b) will increase coverage by 9.82%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #257      +/-   ##
==========================================
+ Coverage   56.47%   66.29%   +9.82%     
==========================================
  Files         214      199      -15     
  Lines        5378     5776     +398     
  Branches      387      262     -125     
==========================================
+ Hits         3037     3829     +792     
+ Misses       2341     1947     -394     
Impacted Files Coverage Δ
src/main/scala/vsys/utils/JsonFileStorage.scala 86.84% <0.00%> (-2.91%) ⬇️
src/main/scala/vsys/wallet/Wallet.scala 92.59% <0.00%> (-1.64%) ⬇️
src/main/scala/vsys/settings/GenesisSettings.scala 100.00% <0.00%> (ø)
...c/main/scala/vsys/api/http/spos/SPOSApiRoute.scala 0.00% <0.00%> (ø)
...main/scala/vsys/api/http/database/DbApiRoute.scala 0.00% <0.00%> (ø)
...cala/vsys/api/http/contract/ContractApiRoute.scala 0.00% <0.00%> (ø)
...ala/vsys/api/http/spos/SPOSBroadcastApiRoute.scala 0.00% <0.00%> (ø)
.../api/http/contract/ContractBroadcastApiRoute.scala 0.00% <0.00%> (ø)
...nsaction/contract/ChangeContractStatusAction.scala
src/main/scala/scorex/transaction/package.scala
... and 226 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad9c72b...a5647a4. Read the comment docs.

@faddat
Copy link
Contributor Author

faddat commented Jan 11, 2021

Same as: #248

But without ARM functionality. It will auto-build docker containers and the like.

@faddat
Copy link
Contributor Author

faddat commented Jan 13, 2021

Hey so I really want just a single set of seeds, shall I remove my seeds from the mainnet configuration?

@faddat faddat marked this pull request as draft January 13, 2021 13:52
@faddat faddat mentioned this pull request Feb 20, 2021
9 tasks
@faddat faddat closed this Feb 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants