Skip to content

Commit

Permalink
Need to update webmin module permissions for phpini after a version c…
Browse files Browse the repository at this point in the history 
…hange https://www.virtualmin.com/node/71108
  • Loading branch information
@jcameron
jcameron committed May 20, 2021
1 parent 94d2a08 commit 4c6068a
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions save_phpmode.cgi
View file
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,7 @@ if (!$anything) {
}

&save_domain($d);
&refresh_webmin_user($d);

This comment has been minimized.

Sign in to view

Copy link
@iliajie

iliajie May 20, 2021

Collaborator

It's not very clear how updating Webmin user has anything to do with PHP. Does it also update some files permissions?

This comment has been minimized.

Sign in to view

Copy link
@swelljoe

swelljoe May 20, 2021

Collaborator

phpini is a Webmin module for managing PHP configs.

This comment has been minimized.

Sign in to view

Copy link
@iliajie

iliajie May 20, 2021

Collaborator

It means ACLs for a user weren't updated to have access to phpini module. It makes sense.

This comment has been minimized.

Sign in to view

Copy link
@jcameron

jcameron May 22, 2021

Author Collaborator

Yeah, this call re-generates the Webmin ACLs, once of which is the phpini module that has a per-user setting for which php.ini files can be edited. This can change when a new PHP version is selected.
&release_lock_logrotate($d) if ($d->{'logrotate'});
&release_lock_dns($d);
&release_lock_web($d);
Expand Down

2 comments on commit 4c6068a

@marclaporte
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the record, this addresses: #290

@iliajie
Copy link
Collaborator

@iliajie iliajie commented on 4c6068a Feb 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I ran deeper tests and there are more issues.

Ref.: virtualmin/virtualmin-nginx#24 (comment)

Please sign in to comment.