-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
4 changed files
with
19 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f5eccbb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added few improvements to the UI.
f5eccbb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we improve that? Something like:
<Location / >
AuthName "Restricted"
AuthType Basic
AuthUserFile /home/domain.tld/.htpasswd
Require ip X.Y.Z.W/27
Require valid-user
f5eccbb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will do.
This may be a good improvement. @jcameron Jamie, what are your thoughts on this?
f5eccbb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something like:
<Location / >
AuthName "Restricted"
AuthType Basic
AuthUserFile /home/domain.tld/.htpasswd
SetEnvIf Request_URI /.well-known noauth=1
Require env noauth
Require env REDIRECT_noauth
Require ip 1.2.3.4/27
Require valid-user
f5eccbb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I wouldn't object to a feature to also limit a path to certain IPs.
f5eccbb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But can you also move the options from .htaccess to the virtual servers config file? Having a problem with sites that have an .htaccess file and just symlinks to it. Virtualmin of course complains that it can't write the file