Quoting is needed when directive contains a ; or $ #26

virtualmin · Apr 2, 2022 · 60915c5 · 60915c5 · iliajie · Aug 4, 2022
1 parent f43470d
commit 60915c5
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/virtualmin-nginx-lib.pl b/virtualmin-nginx-lib.pl
@@ -466,10 +466,10 @@ sub join_words
 	if ($w eq "") {
 		push(@rv, '""');
 		}
-	elsif ($w =~ /\s/ && $w !~ /"/) {
+	elsif ($w =~ /\s|;|\$/ && $w !~ /"/) {
 		push(@rv, "\"$w\"");
 		}
-	elsif ($w =~ /\s/) {
+	elsif ($w =~ /\s|;|\$/) {
 		push(@rv, "'$w'");
 		}
 	else {