Extra checks that we're not replacing nothing https://forum.virtualmi…

…n.com/t/nginx-configuration-failed-restore-of-a-full-rackup/119325
virtualmin · Feb 18, 2023 · e707cad · e707cad
1 parent f3f3408
commit e707cad
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/virtual_feature.pl b/virtual_feature.pl
@@ -2525,7 +2525,8 @@ sub feature_restore
 	}
 
 # Fix up home directory if changed
-if ($oldd && $d->{'home'} ne $oldd->{'home'}) {
+if ($oldd && $d->{'home'} && $oldd->{'home'} &&
+    $d->{'home'} ne $oldd->{'home'}) {
 	&recursive_change_directives(
 		$server, $oldd->{'home'}, $d->{'home'}, 0, 1);
 	}

diff --git a/virtualmin-nginx-lib.pl b/virtualmin-nginx-lib.pl
@@ -1541,6 +1541,7 @@ sub switch_write_user
 sub recursive_change_directives
 {
 my ($parent, $oldv, $newv, $suffix, $prefix, $infix) = @_;
+return if (!$oldv);
 foreach my $dir (@{$parent->{'members'}}) {
 	my $changed = 0;
 	foreach my $w (@{$dir->{'words'}}) {