Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix python api SetDeviceNumber issue, Aliase input0 and output0 #9

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tonychen01
Copy link

No description provided.

@syang100 syang100 requested a review from ccanel October 20, 2018 20:51
Copy link
Member

@ccanel ccanel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@syang100 @tonychen01 Is there a better way to solve this source/sink-naming problem? If the user is trying to add an operator to their pipeline, then shouldn't they know what the sources and sinks are actually called? And for multi-input and multi-output operators, I think that it's perfectly reasonable to expect people to know that these special operators have sources/sinks that end in an index. For the Python API, the boilerplate should handle this issue, not the underlying implementation. In general, problems like this are a sign that the interface is wrong. But if you say that it's too invasive of a problem to fix right now, then I'll approve this patch.

Also, this PR should contain two commits, one for fixing the SetDeviceNumber issue and one for adding the source/sink aliases. But don't worry about fixing it this time.

@ccanel ccanel added the bug Something isn't working label Oct 20, 2018
@tonychen01
Copy link
Author

For the source/sink naming issue, under many circumstances of pipeline have one camera as input, operators which support multi inputs/outpus have input0 output0, this fix coult let user easily aliase name input0 -> input, output0 -> output. For the python API, SetDeviceNumber is a member function of SafPython object, should not definded as global function but a member function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants